549554 - MOZ_X_SYNC evn option does not work in MOZ_QT port

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Add Qt display check

toolkit/xre/nsX11ErrorHandler.cpp
#ifdef MOZ_WIDGET_GTK2
   // Actually, for requests where Xlib gets the reply synchronously,
   // MOZ_X_SYNC=1 will not be necessary, but we don't have a table to tell us
   // which requests get a synchronous reply.

Comment 1

[Oleg Romashin (:romaxa)]

Fixed
http://hg.mozilla.org/mozilla-central/rev/03b8097bf361

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Build fix for missing QX11Info

Comment 3

[James Cook]

You _might_ need to rearrange that chunk of included headers to read...

#ifdef MOZ_WIDGET_GTK2
#include <gdk/gdkx.h>
#elif defined(MOZ_WIDGET_QT)
#include <QX11Info>
#endif
#include <X11/Xlib.h>

to avoid compilation issues in particular versions of Qt.  From what I can see you need to include X11/Xlib.h after QX11Info.

Comment 4

[Mike Kristoffersen (:MikeK)]

(In reply to comment #3)
> You _might_ need to rearrange that chunk of included headers to read...
> 
> #ifdef MOZ_WIDGET_GTK2
> #include <gdk/gdkx.h>
> #elif defined(MOZ_WIDGET_QT)
> #include <QX11Info>
> #endif
> #include <X11/Xlib.h>
> 
> to avoid compilation issues in particular versions of Qt.  From what I can see
> you need to include X11/Xlib.h after QX11Info.

The patch does indeed prevent trunk to build Fennec for Qt in its current form due to that include

Comment 5

[James Cook]

I filed bug 551149 to cover this.

Comment 6

[Mike Kristoffersen (:MikeK)]

You beat me with Bug 551151 on that one ;)