549589 - Implement new location bar and search bar style

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

small icons mode and emptytext color fixed

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

the previous patch unintentionally removed a line break...

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/81a7e5da3c4a

Comment 4

[u88484]

These bugs are really confusing me because the summary and comment 0 are all very vague.  Comment 0 should describe exactly what the changes will entail.

The summary of this bug is "Implement new location bar and search bar style" which to me would be every single change that is displayed in the mockups that relate to the location and search bars.  Where is the star button that is shown to be to the left of the site identity button?  I see there is a separate bug for combining the stop/go/refresh buttons so I can understand that the work for that will be done in that bug but I only know that because I hunted down that information before completing my comment here.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> The summary of this bug is "Implement new location bar and search bar style"
> which to me would be every single change that is displayed in the mockups that
> relate to the location and search bars.

No. It's filed in the Theme component and as such it covers theme changes.

Comment 6

[Peter Lairo]

Please provide a description and/or screenshot-mockup of what this bug is supposed to fix. Slipping in fixes without providing this information is anti-transparent and seems like changes, that may be for the worse, are being slipped-in "under the radar".

Comment 7

[Leman Bennett [Omega]]

Those details were already disclosed:
https://wiki.mozilla.org/Firefox/4.0_Windows_Theme_Mockups

Half of the internet saw it by now.

Comment 8

[Gary [:streetwolf52]]

Minor problem with this change.  If the site is https the location bar increases a pixel or two in height.  Going to a http site reverts it back to normal.  Also the buttons change in height also.

Comment 9

[Dão Gottwald [:dao]]

I'm not seeing this. Please file a bug including screenshots?

Comment 10

[tymerkaev]

Attachment: Screenshot

Here's a screenshot of this ugliness

Comment 11

[Filippo]

(In reply to comment #8)
> Minor problem with this change.  If the site is https the location bar
> increases a pixel or two in height.  Going to a http site reverts it back to
> normal.  Also the buttons change in height also.

Works for me. Have you checked for some installed extension that can cause this problem?

Comment 12

[Gary [:streetwolf52]]

I created a brand new profile and still have the problem.  I file a bug with screenshots.

Comment 13

[Gary [:streetwolf52]]

[url=https://bugzilla.mozilla.org/show_bug.cgi?id=549898]Bug 549898[/url]