Don't unnecessarily [wrap] cleartext for JSON.stringify

RESOLVED FIXED in 1.2

Status

()

RESOLVED FIXED
9 years ago
25 days ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
blocking-weave1.2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.22 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Bug 459161 has been fixed for a while for all the app minversions we support, so we can get rid of the [] wrapping that was originally added for the original nsIJSON implementation.
(Assignee)

Comment 1

9 years ago
Created attachment 429751 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #429751 - Flags: review?(mconnor)
(Assignee)

Updated

9 years ago
Depends on: 549635
(Assignee)

Updated

9 years ago
Blocks: 549781

Updated

9 years ago
Attachment #429751 - Flags: review?(mconnor) → review+
(Assignee)

Updated

9 years ago
Flags: blocking-weave1.2+
Target Milestone: --- → 1.2
(Assignee)

Updated

9 years ago
Depends on: 545517
(Assignee)

Updated

9 years ago
Blocks: 549635
No longer depends on: 549635
(Assignee)

Comment 2

9 years ago
Created attachment 431447 [details] [diff] [review]
v1.1

Additionally bump storage version from bug 545517.
Attachment #429751 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Whiteboard: [has patch][has review]
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/labs/weave/rev/2f5cda207189
Remove the unnecessary indirection now that JSON.stringify can take strings.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.