550154 - PGO build issue on Solaris SPARC

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

There're 2 issues on SPARC
1)
In Bug 425626, we disable pgo for xpcom/reflect/xptcall/src/md/unix on SPARC
The fix doesn't work now.
We need to move NO_PROFILE_GUIDED_OPTIMIZE ahead of include config.mk

2)
-xlinkopt=2 option failed to compile libmozjs.so
Might be a bug of compiler.
We'd remove this option.

Comment 1

[Ginn Chen]

Attachment: patch [Checkin: Comment 2]

Comment 2

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/d659d4463ab1

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Copy it to comm-central [Checkin: Comment 7]

Comment 4

[Ginn Chen]

Serge, I don't think you need to add test "$MOZILLA_1_9_2_BRANCH" = "1";.
This patch should be applied to both 1.9.2 and 1.9.3.

Comment 5

[Justin Wood (:Callek)]

(In reply to comment #4)
> Serge, I don't think you need to add test "$MOZILLA_1_9_2_BRANCH" = "1";.
> This patch should be applied to both 1.9.2 and 1.9.3.

Ginn, are you willing to test TB with a mozilla-1.9.2 tree with a version of this patch without the 1.9.2 test he did here?

We do the test to try and keep the build system in sync for the various mozilla-branches (where it makes sense). I'm just not sure if its worth asking him to write a new patch here if SPARC will fail even with this for TB on 1.9.2 (note: suite doesn't support 1.9.2)

Also no c-c app officially supports PGO at the moment anyway, though we are _trying_ to keep build-system support intact.

Comment 6

[Justin Wood (:Callek)]

(In reply to comment #5)
> I'm just not sure if its worth asking him to write a new patch...

If its tested to work; and patch is written I'm not opposed to taking it though. Just to be clear.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 435068 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/a4617f9d05e3


(In reply to comment #4)
> This patch should be applied to both 1.9.2 and 1.9.3.

In other words, you should land your fix in m-1.9.2 first.!.

Comment 8

[Ginn Chen]

> (In reply to comment #4)
> > This patch should be applied to both 1.9.2 and 1.9.3.
> 
> In other words, you should land your fix in m-1.9.2 first.!.

I'd like to, but I guess drivers are not glad to take tier-n platform changes to stable branches.
e.g. Bug 548218, it blocks the build on Solaris, but didn't get approval yet.