550359 - XML parsing error while searching in api

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Search for https://preview.addons.mozilla.org/en-US/firefox/api/1.5/addon/592

observed behavior:
XML Parsing Error: not well-formed
Location: https://preview.addons.mozilla.org/en-US/firefox/api/1.5/search/we
Line Number 74, Column 1:

Also see:
https://preview.addons.mozilla.org/en-US/firefox/api/1.5/search/we
https://preview.addons.mozilla.org/en-US/firefox/api/1.5/search/you

Comment 1

[Pratibha]

API 1.2 URL: FAIL: https://preview.addons.mozilla.org/en-US/firefox/api/1.2/search/Gmail
shows error message as follows:
XML Parsing Error: not well-formed
Location: https://preview.addons.mozilla.org/en-US/firefox/api/1.2/search/Gmail
Line Number 107, Column 1:
 
API 1.3 URL: FAIL: https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/Gmail
shows error message as follows:
XML Parsing Error: not well-formed
Location: https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/Gmail
Line Number 107, Column 1:

Also failed while searching add-on=Outlook
https://preview.addons.mozilla.org/en-US/firefox/api/1.2/search/Outlook
https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/Outlook
error message: 
XML Parsing Error: not well-formed
Line Number 288, Column 1:

Comment 2

[krupa raj[:krupa]]

one more: https://preview.addons.mozilla.org/en-US/firefox/api/1.2/search/firefox%27s

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Thanks, I think this enough of a representative sample of this bug.  Wait until there's a fix before finding more examples.

Comment 4

[Fred Wenzel [:wenzel]]

fwiw, maybe it's a good idea not to render XML "by hand" in a template, but to have it generated from one of Python's xml writers?

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fred,

Point taken.  I'll look into using a library.

Comment 6

[Fred Wenzel [:wenzel]]

In tuxedo, I use minidom:
http://github.com/fwenzel/tuxedo/blob/master/apps/api/views.py#L250

Setting every attribute etc. like this might get tedious though with more complex files, so maybe another library is more handy in your case.

Comment 7

[Jeff Balogh (:jbalogh)]

I wonder if you could spawn a new Jinja environment that will do xml-safe escaping instead of just html escaping?  I think that would keep us safe without getting bogged down in minidom.  We'd only have to check that the tags we're writing are safe, but that's not hard.

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

note to self... I've verified all the URLs listed to this point... most of them contain the same addon id=592 which has our "^L"

Comment 9

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Took jbalogh's approach - seemed to make more sense for now, although I do see a point of having precise xml being delivered.

Comment 10

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fixed for the issue noted in the bug, but some of the urls supplied are giving 500 errors... I suspect that's another issue.

Comment 11

[krupa raj[:krupa]]

Verified that no XML parsing errors are seen at-
https://preview.addons.mozilla.org/en-US/firefox/api/1.2/search/we
https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/you
https://preview.addons.mozilla.org/en-US/firefox/api/1.5/addon/592
https://preview.addons.mozilla.org/en-US/firefox/api/1.2/search/Outlook