550366 - Location bar doesn't lose "focused" attribute/property when Customize Toolbar window opens

Status: NEW

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: patch v1

STR:
1. Open the DOM Inspector
2. In Firefox window, ensure location bar has focus
3. Open the customize toolbar window from the view menu or toolbar context menu
4. In DOM Inspector, go to #urlbar and see that it has focused="true" attribute and JS focused property = true

I don't know if this patch is the best solution but it fixes the problem.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: patch v1.1

I can't even make simple patches without stupid mistakes. :|

Comment 2

[Dão Gottwald [:dao]]

I suppose this affects the search bar as well? Would be nice to fix this in a generic way...

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Doesn't appear to.

Comment 4

[Dão Gottwald [:dao]]

I suppose the search bar isn't affected because its textbox is anonymous content which gets reconstructed from scratch when customizing toolbars. Still, a more general solution seems preferable. How about removing the attribute in the xbl descructor and adding it back in the constructor in case document.activeElement == this.inputField?

Comment 5

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

That test is never true when the constructor is called due to the urlbar being moved around the DOM. We could call |if (this.focused) this.focus();| in the constructor ... ?

Comment 6

[Dão Gottwald [:dao]]

The node doesn't need to move around for the constructor to run. You could set type="autocomplete", for instance. However, I guess the input field could still not be focused anymore, as the anonymous content would be reconstructed.

"if (this.focused) ..." in the constructor doesn't seem right, as the attribute shouldn't be there anymore in the first place.

Comment 7

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

I can't remove the attribute in the destructor because it doesn't get called (bug 230086). Are there any other opportunities to remove it?

Comment 8

[Dão Gottwald [:dao]]

customizeToolbar.js could check whether focus is inside of the toolbox and clear it in that case.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> customizeToolbar.js could check whether focus is inside of the toolbox and
> clear it in that case.

Geoff, do you want to write such a patch?

Comment 10

[Dão Gottwald [:dao]]

Attachment: patch

This fixes it, but it probably shouldn't be needed. If the input field of a textbox is focused, maybe there should be a blur event before that input field gets destroyed?

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

err, that's what I wanted

Comment 12

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Sorry, I've been way too busy to deal with Mozilla stuff lately.

Comment 13

[Neil Deakin]

Dão, does the patch in bug 559561 fix this?

Comment 14

[Dão Gottwald [:dao]]

(In reply to comment #13)
> Dão, does the patch in bug 559561 fix this?

No, doesn't seem to.

Comment 15

[Neil Deakin]

OK, the patch in bug 559561 is right and the blur does happen, but by the time the event fires the frame for the input has gone away. I'll continue to investigate tomorrow.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #7)
> I can't remove the attribute in the destructor because it doesn't get called
> (bug 230086). Are there any other opportunities to remove it?

Bug 83635, which bug 230086 depends on, is now blocking 1.9.3b1.

Comment 17

[Dão Gottwald [:dao]]

(In reply to Neil Deakin from comment #15)
> OK, the patch in bug 559561 is right and the blur does happen, but by the
> time the event fires the frame for the input has gone away. I'll continue to
> investigate tomorrow.

Any update on this?

Comment 18

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 19

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 20

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.