550515 - [kitsune] Concat and Minify JS and CSS

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[James Socol [:jsocol, :james]]

We should look at something like one of the following:

http://github.com/mintchaos/django_compressor#readme
http://code.google.com/p/django-compress/wiki/Usage
AMO's YUICompressor-based app.

We should give these (and possibly other options) a quick once over and see which one makes us happiest.

Comment 1

[James Socol [:jsocol, :james]]

(For the record, so far I like the first one the most, because it keeps all the JS and CSS exclusively in the templates, with just a couple wrappers.)

Comment 2

[James Socol [:jsocol, :james]]

AMO's may be the best option, given that we're using Jinja. The other options in comment 0 are pretty Django-template specific.

Comment 4

[James Socol [:jsocol, :james]]

This was unassigned for a while because it bounced around between me and Paul.

I got the app out of AMO and put it up and http://github.com/jsocol/jingo-minify

This patch is based on that:
http://github.com/jsocol/kitsune/commit/f159b8f25ea78c38cc7e60fae6004ccb5e1273c6

Comment 5

[James Socol [:jsocol, :james]]

Paul, r?
http://github.com/jsocol/kitsune/compare/bug-550515

Comment 6

[Paul Craciunoiu [:paulc]]

All works except results.html needs to be updated with the new css value, on line 4.

Comment 7

[James Socol [:jsocol, :james]]

Merged to development with the changes from comment 6.

http://github.com/jsocol/kitsune/commit/1c6f3dc864e9e4402e08786e3755a23744bc473f

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, showing Firebug's "Net," "All" panels

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.