550547 - redirection to addon homepage for listed addons does not work

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Vishal Kamdar [:vish_moz]]

Attachment: newest addons sorted by date

redirection to addon homepage does not work from the sorted list page
https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:all?sort=newest

STR:
1. go to AMO preview https://preview.addons.mozilla.org/en-US/firefox
2. under 'browse addons' click on 'Just added'
3. scroll down and click on 'view all newly created addons' https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:all?sort=newest
4. click on 'View Homepage' button for one of the listed addons

Actual result:
you do not get redirected

Expected result:
you should get redirected to the listed addon Homepage

Note: If you go to that listed addons details page and then click 'View Homepage', you will be redirected successfully.

Comment 1

[Jeff Balogh (:jbalogh)]

The Continue To Homepage button is pointing at the current URL (the browse page) instead of the external link.

Comment 2

[Vishal Kamdar [:vish_moz]]

redirection does not work from user profile page either,
https://preview.addons.mozilla.org/en-US/firefox/user/5143311

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> redirection does not work from user profile page either,
> https://preview.addons.mozilla.org/en-US/firefox/user/5143311

Can you be more specific please?  I didn't see any problems there.

Comment 4

[Vishal Kamdar [:vish_moz]]

(In reply to comment #3)
> (In reply to comment #2)
> > redirection does not work from user profile page either,
> > https://preview.addons.mozilla.org/en-US/firefox/user/5143311
> 
> Can you be more specific please?  I didn't see any problems there.

STR:
1. go to https://preview.addons.mozilla.org/en-US/firefox/user/5143311
2. scroll down to "Facebook Toolbar" addon
3. click on "view homepage" button

Actual result:
you do not get redirected to that addon's homepage.

Comment 5

[Wil Clouser [:clouserw]]

This is caused by having multiple homepage buttons on the same page.  It looks like it loops through every button in the init, and you're hitting "if (!match)" on line 2360 of addons.js and hiding the popup.  So, the popups are working, they are just getting hidden before you can see them.

Comment 6

[Jeff Balogh (:jbalogh)]

Attachment: bind the trigger after we know what slideBox to look at

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 432905 [details] [diff] [review]
bind the trigger after we know what slideBox to look at

hell yeah

Comment 8

[Jeff Balogh (:jbalogh)]

r64256

Comment 9

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.