550586 - Allow records to mark how long they should be kept (ttl)

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ed Lee :Mardak]

This could be used for the client to hint to the server that a record can/should be deleted after some time.

Comment 1

[Toby Elliott [:telliott]]

I think this should be a X-Record-Keep-Until header that applies to all objects in the PUT/POST. Objections?

Comment 2

[Ed Lee :Mardak]

The value for ttl will be sent as part of the payload of the WBOs in seconds until it may be removed.

Comment 4

[Toby Elliott [:telliott]]

Attachment: Adds ttl functionality as a valid wbo parameter

This handles everything but the background cleanup script that we'll need to purge old ttls

Comment 5

[Tarek Ziadé (:tarek)]

There's a typo in your patch, that breaks an API:

  $sth->bindParam(':username', time());


That's in weave_storage/mysql.php get_collection_storage_totals

I think we should to have some minimal functional tests for the quota code in the PHP before it goes live, to exercise it a bit.

Comment 6

[Toby Elliott [:telliott]]

Attachment: Revised patch to fix typos

hah, good catch. That was in the quota code and I happened to have those tests off on my box.

Comment 7

[Toby Elliott [:telliott]]

Changes in http://hg.mozilla.org/services/sync-server/rev/f1418ab3a8ce

Comment 8

[Trever Adams]

Can we see a README update, or some other way of knowing what type ttl should be in the database schema so that we can still setup our own servers?

Thank you.

Comment 9

[Toby Elliott [:telliott]]

I'm prepping a post on that. It's an int(11).

Will update the README.