550659 - Using a symlinked greDir fails to launch application from nsXULStub

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mike Hommey [:glandium]]

+++ This bug was initially created as a clone of Bug #530196 +++

> A xulrunner-stub based application where the GRE (xulrunner) is on a symlinked
> folder will fail to launch. I have not been able to find the exact place the
> failure occurs. But I have a simple patch to fix the problem. The patch simply 
> resolves the symlink in the stub before initializing XPCOM.

This still applies in some cases where the GRE directory is determined in another place in the code path (e.g. $APP_DIR/xulrunner exists). Moving the symlink resolution to be unconditional should solve the issue.

Note the symlinked GRE issue doesn't exist in 1.9.1, so this is a regression in 1.9.2. I don't know if there is a bug tracking this particular issue.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

(the patch is against 1.9.2)

Comment 2

[Mike Hommey [:glandium]]

Attachment: For reference, a more readable diff -w version

Comment 3

[Mike Hommey [:glandium]]

(In reply to comment #0)
> Note the symlinked GRE issue doesn't exist in 1.9.1, so this is a regression in
> 1.9.2. I don't know if there is a bug tracking this particular issue.

It also seem to have more impact than the stub problem. It looks like it induces problems with symlinked profiles and symlinked extensions.

Comment 4

[Mike Hommey [:glandium]]

A real fix for the underlying issue is in bug 551152, but I think the symlink resolution should be kept anyways, and moved as done by the attached patch.

Comment 5

[Benjamin Smedberg]

Comment on attachment 430808 [details] [diff] [review]
Patch

I think this bug got obsoleted by the gre-finding removal, but in any case the code has changed in ways that make the patch unusable.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Resolve the xulrunner path when it is a symbolic link in the xulrunner stub

bug 551152 has been fixed, but I still thought the symbolic link should be resolved, though I'm not sure why, now. Probably for components registration (xxpti.dat used to contain full paths).

The new code after the gre-finding removal doesn't do the symbolic link resolution anymore, so this is a patch that adds it back, but I'm not sure we need that now.

Comment 7

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b774154497e1

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b774154497e1