550666 - Builds broken in memory/mozalloc/mozalloc.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Marco Perez [:mpk]]

Attachment: #include <unistd.h> (so the *BSDs find valloc; patch for mozilla-central)

Since the fix for bug 441324 landed, builds for all mozilla apps on FreeBSD
(NetBSD and OpenBSD probably too) fail quite early with the following error:

...
gmake[6]: Entering directory `/work/build/browser/memory/mozalloc'
mozalloc.cpp
mozalloc_oom.cpp
/work/src/mozilla/memory/mozalloc/mozalloc.cpp:
    In function 'void* moz_xvalloc(size_t)':
/work/src/mozilla/memory/mozalloc/mozalloc.cpp:196:
    error: 'valloc' was not declared in this scope
/work/src/mozilla/memory/mozalloc/mozalloc.cpp:
    In function 'void* moz_valloc(size_t)':
/work/src/mozilla/memory/mozalloc/mozalloc.cpp:206:
    error: 'valloc' was not declared in this scope
gmake[6]: *** [mozalloc.o] Error 1
gmake[6]: Leaving directory `/work/build/browser/memory/mozalloc'
...

*BSD defines valloc in unistd.h (see http://man.freebsd.org/valloc)

Comment 1

[Marco Perez [:mpk]]

Attachment: patch v2 (mozilla-central)

Unconditionally including unistd.h would cause problems on Windows.
This patch includes <unistd.h> only if XP_UNIX is defined.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Unfortunately it appears this has bitrotted.  Can you update the patch Marco?

Comment 4

[Marco Perez [:mpk]]

Attachment: unbitrotted variant of the reviewed patch v2 (mozilla-central)

Oops, it looks like rev bbbb2d668d0d (bug 550401) touched that file last thursday.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/1a6aac2558e4