556048 - FreeBSD Firefox builds fail in mozilla/memory/mozalloc.cpp due to missing include

Status: RESOLVED DUPLICATE of bug 550666

(Core :: XPCOM, defect)

Description

[Jonathan Leighton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: mozilla-central rev. e3de007bd5b9

In early March 2010 mozilla/memeory/mozalloc.cpp was introduced to the code base and since that time FreeBSD builds fail.  mozalloc.cpp calls valloc, but doesn't include the unistd.h header file, which is required for valloc on FreeBSD.


Reproducible: Always

Steps to Reproduce:
1. Pull mozilla-central source from anytime after mozalloc.cpp was introduced (early March 2010)
2. Build Firefox on FreeBSD
3.
Actual Results:  
c++ -o mozalloc.o -c  -DOSTYPE=\"FreeBSD7\" -DOSARCH=FreeBSD 
-I../../../memory/mozalloc -I. -I../../dist/include
-I../../dist/include/nsprpub 
-I/home/leighton/development/firefox/source/sctp/trunk/mozilla/obj-ff-dbg-no-sctp/dist/include/nspr
-I/home/leighton/development/firefox/source/sctp/trunk/mozilla/obj-ff-dbg-no-sctp/dist/include/nss
      -fPIC -I/usr/local/include -fno-rtti -fno-exceptions -Wall
-Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros
-Werror=return-type -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar
-pipe  -DDEBUG -D_DEBUG -DDEBUG_leighton -DTRACING -g  -I/usr/local/include
-DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/mozalloc.pp
../../../memory/mozalloc/mozalloc.cpp
../../../memory/mozalloc/mozalloc.cpp: In function 'void* moz_xvalloc(size_t)':
../../../memory/mozalloc/mozalloc.cpp:196: error: 'valloc' was not declared in
this scope
../../../memory/mozalloc/mozalloc.cpp: In function 'void* moz_valloc(size_t)':
../../../memory/mozalloc/mozalloc.cpp:206: error: 'valloc' was not declared in
this scope

Expected Results:  
Successful build

See comments on bug 550692.

Comment 1

[Jonathan Leighton]

Attachment: patch to add include directive to mozalloc.cpp

Comment 2

[zug_treno]

Duplicate of bug 550666?

Comment 3

[Jonathan Leighton]

Exactly the same - sorry I missed that one.