550821 - [10.6] Blank tooltips when hovering over separator bar in Bookmark Manager

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: General, defect)

Description

[Lisa Thompson]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en; rv:1.9.0.18) Gecko/2010021619 Camino/2.0.2 (like Firefox/3.0.18)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en; rv:1.9.0.18) Gecko/2010021619 Camino/2.0.2 (like Firefox/3.0.18)

Blank tooltips appear when the mouse is over a separator bar in the Bookmark Manager. Neither a blank tooltip, nor any tooltip for a separator bar, seems useful.


Reproducible: Always

Comment 1

[Chris Lawson (gone)]

Turns out this is 10.6-only; neither Smokey nor hendy could repro this on 10.5 but I can reproduce it 100% on 10.6 and so can Philippe.

It looks like 10.6 + our current ExtendedOutlineView tooltip code will happily display a tooltip for either an empty string (which is what our current code returns for separators) or a nil string (which I also tried). I have no idea how to fix that, unfortunately. (I guess if we can't figure out how to fix it, displaying "Bookmark Separator" or something in the tooltip is preferable to just throwing a blank up there, though.)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Suppress tooltips altogether for separators

I posited to cl in the channel that maybe we could have the tooltip code query the cell to see if it was a separator and then bail.  Lo and behold, there's some nice query code in outlineView:willDisplayCell:forTableColumn: when we decide to draw the separator, so I just plugged that into outlineView:tooltipStringForItem:

I think this will work, but since I'm on 10.5, I can't test; I built and it built and didn't blow up my debug build, which is at least a start…

Comment 3

[Chris Lawson (gone)]

Comment on attachment 480687 [details] [diff] [review]
Suppress tooltips altogether for separators

Unfortunately, that isn't the problem. We already return nil out of this method, and that doesn't solve the problem anyway -- the ExtendedOutlineView code is still more than happy to take a nil string and stick it into a tooltip.

What we need to figure out is why the Location column doesn't have this problem, and how to apply that to the Title column.

I don't *think* "don't give separators a title" is an option, or at least the way I tried it wasn't, because AppKit got very upset with me :-p

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Additional non-bug-fixing patch, for reference

Chris noted that I'd mis-read the problem; that patch still returns nil to the code in EOV.

This patch was a failed attempt at patching the logic in EOV, which is completely wrong because I'm checking a poorly-named BOOL.

Ultimately, if the bug is that AppKit blithely draws tooltips for nil, it seems like there's no way for us to fix this, since we init result to nil in EOV (yet, for some reason, the separator's empty location column works fine).

And if this is an OS bug, someone needs get a test app and rdar:// it.

Comment 5

[Chris Lawson (gone)]

(In reply to comment #4)
> This patch was a failed attempt at patching the logic in EOV, which is
> completely wrong because I'm checking a poorly-named BOOL.

I've filed bug 601770 for that.

Comment 6

[Chris Lawson (gone)]

Turns out the tooltips I was seeing are the Cocoa-generated tooltips, *not* Camino-generated tooltips. Lisa and Philippe, can you check to see if you're also seeing Cocoa tooltips in this case?

The way to tell the difference is that the Cocoa tooltips appear immediately under the head of the arrow cursor, whereas ours appear just below and slightly right of the tail of the arrow cursor. (The History view has *only* Cocoa tooltips right now, for comparison purposes.)

Assuming that what everyone else saw here was also Cocoa tooltips (and not Camino's tooltips), this bug is really a special case of bug 458259.

Comment 7

[philippe (part-time)]

(In reply to comment #6)
Yeah, those are Cocoa tooltips over here.

Comment 8

[Lisa Thompson]

Yes, I'm seeing Cocoa tooltips now and I'm sure that's all I saw when I filed this.