550844 - Complete fixing up unit test for bug 526733 (installation of extensions via application/x-xpinstall type)

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mark Banner (:standard8)]

In bug 526733 we tried to get a unit test landing for testing out notification bars and other things relating to installations of extensions in content tabs via application/x-xpinstall types.

We need to complete fixing up those tests and getting them to land.

See comments 6 to 10 on that bug.

Assigning to Andrew as he did the original mods.

Comment 1

[Mark Banner (:standard8)]

Attachment: WIP

I took a brief look at this today, as I need to use the notificationbars in a different test... This patch is basically the same file as we originally landed with bug 526733, with the exception that there is a 55 millisecond sleep added at the end of install.xpi.

It still fails occasionally on my setup, but a lot less with this in.

My current theory is that either:

- mozmill is trying to do stuff too soon after the modal xpinstall dialog
or
- the modal xpinstall dialog is blocking the notification going away until the modal dialog has cleared, and it just doesn't fire the AlertFired notification as a result.

Comment 2

[Mark Banner (:standard8)]

(hence asking asuth what he thinks about this).

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Please attach a log of the failure with your extra debug.  It doesn't fail for me, and the log would simplify my analysis.

Comment 4

[Mark Banner (:standard8)]

Attachment: Log of failure

Here's the log of the failure with some added debugging, but don't let this get in the way of b2 stuff...

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

I've looked at this a bit, but I think this is one of those cases where we either:

A) Need more data.

or

B) Need to just crank timeouts up.

'A' implies having bug 556848 resolved so we can get structured data out.  B seems straightforward.  rs=asuth to randomly add and increase timeouts as the situation demands.

Comment 6

[Mark Banner (:standard8)]

Unit tests have moved to bug 571759 now that there's a revised add-on manager implementation.

Comment 7

[Mark Banner (:standard8)]

Fixed by attachment 503816 [details] [diff] [review] in bug 571759