551390 - Dead code in content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ehren Metcalfe]

Attachment: patch

These functions are unused: 

in content/base:

PRBool nsParserUtils::GetQuotedAttrNameAt(const nsString&,PRUint32,nsAString_internal&)
http://mxr.mozilla.org/mozilla-central/search?string=GetQuotedAttrNameAt

nsIContent* nsContentUtils::FindFirstChildWithResolvedTag(nsIContent*,PRInt32,nsIAtom*)
http://mxr.mozilla.org/mozilla-central/search?string=FindFirstChildWithResolvedTag

nsIDocShell* nsContentUtils::GetDocShellFromCaller()
http://mxr.mozilla.org/mozilla/search?string=GetDocShellFromCaller

nsIContent* nsContentUtils::GetReferencedElement(nsIURI*,nsIContent*)
http://mxr.mozilla.org/mozilla-central/search?string=GetReferencedElement

void nsXMLNameSpaceMap::RemovePrefix(nsIAtom*)
http://mxr.mozilla.org/mozilla-central/search?string=RemovePrefix

content/html:

void nsGenericHTMLElement::GetHrefURIToMutate(nsIURI**)
http://mxr.mozilla.org/mozilla-central/search?string=GetHrefURIToMutate

nsresult nsGenericHTMLElement::SetFloatAttr(nsIAtom*,float)
http://mxr.mozilla.org/mozilla-central/search?string=SetFloatAttr

nsresult nsGenericHTMLElement::GetFloatAttr(nsIAtom*,float,float*)
http://mxr.mozilla.org/mozilla-central/search?string=GetFloatAttr

nsresult nsHTMLDNSPrefetch::PrefetchHigh(nsAString_internal&)
nsresult nsHTMLDNSPrefetch::PrefetchHigh(Link*)
http://mxr.mozilla.org/mozilla-central/search?string=PrefetchHigh

nsresult nsHTMLDNSPrefetch::PrefetchMedium(nsAString_internal&)
nsresult nsHTMLDNSPrefetch::PrefetchMedium(Link*)
http://mxr.mozilla.org/mozilla-central/search?string=PrefetchMedium

PRBool SinkContext::IsAncestorContainer(nsHTMLTag)
http://mxr.mozilla.org/mozilla-central/search?string=IsAncestorContainer

nsresult nsHTMLFragmentContentSink::AddTextToContent(nsIContent*,const nsAString_internal&)
http://mxr.mozilla.org/mozilla-central/search?string=AddTextToContent

content/media:

nsresult nsMediaCacheStream::ReadFromCache(char*,PRInt64,PRInt64)
http://mxr.mozilla.org/mozilla-central/search?string=ReadFromCache

Comment 1

[Boris Zbarsky [:bzbarsky]]

The content/base list of things removed looks ok to me, though sicking is a better reviewer I think.

GetHrefURIToMutate can go.  But then you should be able to remove the aCloneIfCached argument of GetURIAttr too, right?

>nsresult nsGenericHTMLElement::SetFloatAttr(nsIAtom*,float)
>http://mxr.mozilla.org/mozilla-central/search?string=SetFloatAttr
>
>nsresult nsGenericHTMLElement::GetFloatAttr(nsIAtom*,float,float*)
>http://mxr.mozilla.org/mozilla-central/search?string=GetFloatAttr

Not sure whether we'll need these for upcoming html5 stuff.

> nsresult nsHTMLDNSPrefetch::PrefetchHigh(nsAString_internal&)
> nsresult nsHTMLDNSPrefetch::PrefetchHigh(Link*)
> http://mxr.mozilla.org/mozilla-central/search?string=PrefetchHigh

> nsresult nsHTMLDNSPrefetch::PrefetchMedium(nsAString_internal&)
> nsresult nsHTMLDNSPrefetch::PrefetchMedium(Link*)
> http://mxr.mozilla.org/mozilla-central/search?string=PrefetchMedium

These were meant as forward-looking API, in case someone needs them.

> nsresult nsMediaCacheStream::ReadFromCache(char*,PRInt64,PRInt64)
> http://mxr.mozilla.org/mozilla-central/search?string=ReadFromCache

This needs review from roc.

Comment 2

[[e-mail]]

Awesome to see dead code bugs being filed!

Comment 3

[Ehren Metcalfe]

Attachment: patch v2

Sorry this took so long... 

I put back Prefetch* and *FloatAttr. Also I wonder if I can sneak in nsresult nsPlainTextSerializer::WillProcessTokens() : http://mxr.mozilla.org/mozilla-central/search?string=WillProcessTokens (It looks like it implements an interface method that was removed at some point)

Comment 4

[Ehren Metcalfe]

I also removed aCloneIfCached from GetURIAttr. Should probably try a build with -Wunusedparams ...

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ehren, is there anything left to do before this can land?

Comment 6

[Ehren Metcalfe]

Attachment: patch for check-in

oops, sry for the epic delay.

Here's the rebased patch. Unfortunately/Fortunately nsMediaStream::ReadFromCache now has users so I had to take that out of the patch. The rest passed a minimal try server run though so I'll just carry over the r=sicking,roc

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/a968d7ebe290

Thank you for your contribution :)