The default bug view has changed. See this FAQ.

Option to delete manually marked Junk is in wrong place

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Account Manager
--
enhancement
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: tomm174, Assigned: aceman)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 18.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.91 KB, patch
mconley
: review+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.1.8) Gecko/20100202 Firefox/3.5.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.1.8) 

There seems no logic to locating the option to automatically delete when a mail is marked as Junk in
Tools > Options > Security > Junk > 'When I mark messages as junk: Move them to
the account's "Junk" folder

I can only guess that this got located in @Security' because it is a global rather than a per-account setting.  
This does not seem a good reason to separate (I nearly said 'hide') these options in a different place from the rest of the Junk settings.

There would be room for a 'Global settings' area on the junk settings section of individual accounts. This would be more logical.

Reproducible: Always

Steps to Reproduce:
1/ Try to set Tbird to delete mails when I mark them as Junk
2/ Looking in the account's Junk settings
3/ "Where the hell has that setting gone"
4/ Google 
5/ Curse
6/ Google some more 
Actual Results:  
Junk mail settings are separated for no clearly understandable reason

Expected Results:  
All junk mail settings should be together
Component: General → Account Manager
QA Contact: general → account-manager
(Assignee)

Comment 1

5 years ago
Similar to bug 360891, I'll look if some link/button can be made from account manager to the global preferences.
Severity: trivial → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
(Assignee)

Updated

5 years ago
Assignee: nobody → acelists
(Assignee)

Comment 2

5 years ago
Bug 718139 has infrastructure to allow opening a specific tab in the Preferences dialog. That can be used here.
Depends on: 718139
(Assignee)

Updated

5 years ago
Blocks: 352428

Comment 3

5 years ago
Maybe the work in this bug may be a good occasion to ask if it is necessary to add per account settings for "Do not mark mail as junk if the sender is in...".

I really don't see any case were someone would like to have per account settings for this.

And we may also have to ask if it is really needed to differentiate this setting per address books. Maybe simply something like "Do not mark mail as junk if the sender is in one of my address books" would be sufficient for 99% of our users.

Would you like me to create new bug if you think it could be considered?

Comment 4

5 years ago
See also:
Bug 323159 - Make obvious that "Junk mail log" is only for the "adaptive junk mail control" ("Trust junk mail headers set by:" should be consistent in UI and log location/access)
(Assignee)

Comment 5

5 years ago
Bug 323159 is fixed since TB14 so what did you mean with referencing it?

Comment 6

5 years ago
(In reply to :aceman from comment #5)
> Bug 323159 is fixed since TB14 so what did you mean with referencing it?

Both bugs seem indicative of a larger problem with how to deal with junk controls. Maybe if whoever is working on this one sees that one, they might be able to coordinate, since this whole shootin' match seems pretty disjointed otherwise. Just trying to help here as a "tester". Thanks.
aceman, bug 482648 may be informative
(Assignee)

Comment 8

5 years ago
Surely, but too hard for me.
(Assignee)

Comment 9

5 years ago
Created attachment 656217 [details] [diff] [review]
patch

Bwinton please check if the space between the button from the item above it is fine and also if the position of the button is OK. I find it a bit ugly but can't think of a better version now.

Ian, please check if this opens the proper tab in Seamonkey.
Attachment #656217 - Flags: ui-review?(bwinton)
Attachment #656217 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Component: Account Manager → Account Manager
Product: Thunderbird → MailNews Core

Comment 10

5 years ago
Comment on attachment 656217 [details] [diff] [review]
patch

Is there a similar bug for "Composition & Addressing"?
Attachment #656217 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 11

5 years ago
I am not aware of any. But if you find/file one I'd be glad to fix it :)

Comment 12

5 years ago
(In reply to :aceman from comment #11)
> I am not aware of any. But if you find/file one I'd be glad to fix it :)

Bug 788429 created.
Comment on attachment 656217 [details] [diff] [review]
patch

>+++ b/mailnews/base/prefs/content/am-junk.xul
>@@ -218,10 +218,19 @@
>+    <separator/>
>+
>+    <hbox pack="start">
>+      <button id="globalJunkPrefsLink"
>+              label="&globalJunkPrefs.label;"
>+              accesskey="&globalJunkPrefs.accesskey;"
>+              oncommand="showGlobalJunkPrefs();"/>
>+    </hbox>
>+

I feel that this button is a little further down than I would like.  (Comparing it to the "Manage Identities" button, it's almost twice as far down.)  It looks a little close without the separator, though.  Perhaps have a thin separator instead?  Yeah, that looks nicer, and more consistent…

ui-r=me with the separator changed to '<separator class="thin"/>'.

Thanks,
Blake.
Attachment #656217 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 14

5 years ago
Created attachment 660512 [details] [diff] [review]
patch v2

Thanks, no problem.
Attachment #656217 - Attachment is obsolete: true
Attachment #660512 - Flags: review?(mconley)
Comment on attachment 660512 [details] [diff] [review]
patch v2

Review of attachment 660512 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good to me. Thanks, aceman!
Attachment #660512 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2db3eae10e3d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.