Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add ability to open global Addressing preferences from account manager

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Account Manager
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ian Neal, Assigned: aceman)

Tracking

Trunk
Thunderbird 18.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

9.52 KB, patch
Ian Neal
: review+
mconley
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
Bug 551827 added the ability to open global junk preferences from the relevant pane(s) in account manager, we should probably add something similar for Addressing.
(Assignee)

Comment 1

5 years ago
I assume the spec is:
On the Composition & Addressing (there is enough space) add a button to open the Composition pane, General tab in Thunderbird.
What is the equivalent in Seamonkey? I could find some Compose options in pref-character_encoding.xul, but I don't think that is the right place to go to.
Assignee: nobody → acelists
(Reporter)

Comment 2

5 years ago
Probably in http://mxr.mozilla.org/comm-central/source/suite/mailnews/addrbook/prefs/pref-addressing.xul
(Assignee)

Comment 3

5 years ago
Created attachment 663839 [details] [diff] [review]
patch

This could be it, however I get an error of undefined property compositionGroupTitle.label. I do not understand why that would be the case. Ian, can you see it?
Attachment #663839 - Flags: feedback?(iann_bugzilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 4

5 years ago
Comment on attachment 663839 [details] [diff] [review]
patch

>+<!ENTITY globalComposingPrefs.label           "Global Composing Preferencesâ.¦">
Your encoding of the ellipses seems to be what is causing the problems in both .dtd files.

>+  openPrefsFromAccountManager("paneCompose", "addressingTab", null, "addressing_pane");
You've not loaded amUtils.js from am-addressing.xul so this function cannot be found.

>+++ b/suite/locales/en-US/chrome/mailnews/pref/am-addressing.dtd
>+<!ENTITY globalAddressingPrefs.label          "Global Addressing Preferencesâ.¦">
>+<!ENTITY globalAddressingPrefs.accesskey      "A">
A is already in use for SM, "b" or "P" seem to be available.
Attachment #663839 - Flags: feedback?(iann_bugzilla) → feedback-
(Assignee)

Comment 5

5 years ago
Created attachment 664214 [details] [diff] [review]
patch v2

Good catches, thanks.
Attachment #663839 - Attachment is obsolete: true
Attachment #664214 - Flags: ui-review?(bwinton)
Attachment #664214 - Flags: review?(iann_bugzilla)
(Reporter)

Updated

5 years ago
Attachment #664214 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 664214 [details] [diff] [review]
patch v2

Yeah, I like it.  ui-r=me!

Thanks,
Blake.
Attachment #664214 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Attachment #664214 - Flags: review?(mconley)
Comment on attachment 664214 [details] [diff] [review]
patch v2

Review of attachment 664214 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good! Thanks!
Attachment #664214 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/fa763c9a6aba
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.