788429 - Add ability to open global Addressing preferences from account manager

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, enhancement)

Description

[Ian Neal]

Bug 551827 added the ability to open global junk preferences from the relevant pane(s) in account manager, we should probably add something similar for Addressing.

Comment 1

[:aceman]

I assume the spec is:
On the Composition & Addressing (there is enough space) add a button to open the Composition pane, General tab in Thunderbird.
What is the equivalent in Seamonkey? I could find some Compose options in pref-character_encoding.xul, but I don't think that is the right place to go to.

Comment 2

[Ian Neal]

Probably in http://mxr.mozilla.org/comm-central/source/suite/mailnews/addrbook/prefs/pref-addressing.xul

Comment 3

[:aceman]

Attachment: patch

This could be it, however I get an error of undefined property compositionGroupTitle.label. I do not understand why that would be the case. Ian, can you see it?

Comment 4

[Ian Neal]

Comment on attachment 663839 [details] [diff] [review]
patch

>+<!ENTITY globalComposingPrefs.label           "Global Composing Preferencesâ.¦">
Your encoding of the ellipses seems to be what is causing the problems in both .dtd files.

>+  openPrefsFromAccountManager("paneCompose", "addressingTab", null, "addressing_pane");
You've not loaded amUtils.js from am-addressing.xul so this function cannot be found.

>+++ b/suite/locales/en-US/chrome/mailnews/pref/am-addressing.dtd
>+<!ENTITY globalAddressingPrefs.label          "Global Addressing Preferencesâ.¦">
>+<!ENTITY globalAddressingPrefs.accesskey      "A">
A is already in use for SM, "b" or "P" seem to be available.

Comment 5

[:aceman]

Attachment: patch v2

Good catches, thanks.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 664214 [details] [diff] [review]
patch v2

Yeah, I like it.  ui-r=me!

Thanks,
Blake.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 664214 [details] [diff] [review]
patch v2

Review of attachment 664214 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good! Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/fa763c9a6aba