Last Comment Bug 788429 - Add ability to open global Addressing preferences from account manager
: Add ability to open global Addressing preferences from account manager
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Account Manager (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Thunderbird 18.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-05 01:37 PDT by Ian Neal
Modified: 2012-10-02 16:07 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (9.32 KB, patch)
2012-09-23 12:45 PDT, :aceman
iann_bugzilla: feedback-
Details | Diff | Review
patch v2 (9.52 KB, patch)
2012-09-24 14:25 PDT, :aceman
iann_bugzilla: review+
mconley: review+
bwinton: ui‑review+
Details | Diff | Review

Description Ian Neal 2012-09-05 01:37:37 PDT
Bug 551827 added the ability to open global junk preferences from the relevant pane(s) in account manager, we should probably add something similar for Addressing.
Comment 1 :aceman 2012-09-05 04:38:16 PDT
I assume the spec is:
On the Composition & Addressing (there is enough space) add a button to open the Composition pane, General tab in Thunderbird.
What is the equivalent in Seamonkey? I could find some Compose options in pref-character_encoding.xul, but I don't think that is the right place to go to.
Comment 3 :aceman 2012-09-23 12:45:31 PDT
Created attachment 663839 [details] [diff] [review]
patch

This could be it, however I get an error of undefined property compositionGroupTitle.label. I do not understand why that would be the case. Ian, can you see it?
Comment 4 Ian Neal 2012-09-24 14:07:22 PDT
Comment on attachment 663839 [details] [diff] [review]
patch

>+<!ENTITY globalComposingPrefs.label           "Global Composing Preferencesâ.¦">
Your encoding of the ellipses seems to be what is causing the problems in both .dtd files.

>+  openPrefsFromAccountManager("paneCompose", "addressingTab", null, "addressing_pane");
You've not loaded amUtils.js from am-addressing.xul so this function cannot be found.

>+++ b/suite/locales/en-US/chrome/mailnews/pref/am-addressing.dtd
>+<!ENTITY globalAddressingPrefs.label          "Global Addressing Preferencesâ.¦">
>+<!ENTITY globalAddressingPrefs.accesskey      "A">
A is already in use for SM, "b" or "P" seem to be available.
Comment 5 :aceman 2012-09-24 14:25:35 PDT
Created attachment 664214 [details] [diff] [review]
patch v2

Good catches, thanks.
Comment 6 Blake Winton (:bwinton) (:☕️) 2012-10-01 08:18:41 PDT
Comment on attachment 664214 [details] [diff] [review]
patch v2

Yeah, I like it.  ui-r=me!

Thanks,
Blake.
Comment 7 Mike Conley (:mconley) - (needinfo me!) 2012-10-02 14:01:17 PDT
Comment on attachment 664214 [details] [diff] [review]
patch v2

Review of attachment 664214 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good! Thanks!
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-10-02 16:07:52 PDT
https://hg.mozilla.org/comm-central/rev/fa763c9a6aba

Note You need to log in before you can comment on or make changes to this bug.