552042 - Calendar registry not written after creating/deleting calendar

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

STR:

1. Create a new calendar
2. Crash (Ctrl+C in console works too)
3. Restart

Actual Result:
* The prefs file is not written so the calendar is gone

Expected
* The prefs file should be written right away to avoid dataloss.

Comment 1

[Markus Adrario [:Taraman]]

Comment on attachment 432221 [details] [diff] [review]
Fix - v1

patch looks good.

Just remove additional newline here:
>@@ -453,16 +464,18 @@ calCalendarManager.prototype = {
>                 selectPrefs.reset();
>             }
> 
>             let sortOrderAr = [];
>             for each (let s in sortOrder) {
>                 sortOrderAr.push(s);
>             }
>             cal.setPref("calendar.list.sortOrder", sortOrderAr.join(" "));
>+            flushPrefs();
>+
> 
>         } finally {

with that style-nit fixed
r=markus

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c92a7236e227>

-> FIXED