552077 - allow for additional parameters for autoconfig

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Rafael Ebron (:rebron)]

Need to allow additional parameters to be appended to the autoconfig urls and still have the domain info component work.

Example:
?=momo1
https://live.mozillamessaging.com/autoconfig/?=momo1

Comment 1

[David Ascher (:davida)]

Hmm, I don't understand this bug. AFAIK the current URLs used by TB are of the form:

https://live.mozillamessaging.com/autoconfig/gmail.com

I guess this says that we want Thunderbird to generate URLs of the form:

https://live.mozillamessaging.com/autoconfig/gmail.com?momo1

but I don't know where the parameter comes from.  Is the idea that the pref file (e.g. in a funnelcake) can configure an extra pref, and that that option is appended as a query parameter?

Comment 2

[Rafael Ebron (:rebron)]

https://live.mozillamessaging.com/autoconfig/gmail.com?=momo1

Right so that value is the same that we'll carry through from the download site all the way through to the start and what's new page.

In aggregate, we should be able to see how many people hit autoconfig from funnel cake builds.  

Funnel cake builds don't alter the user-agent string.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to substitute in some values for tokens.

With this patch, we turn "https://live.mozillamessaging.com/autoconfig/{{domain}}?rebron=momo1&accountCount={{accounts}}" into "https://live.mozillamessaging.com/autoconfig/latte.ca?rebron=momo1&accountCount=8".

We also turn "https://live.mozillamessaging.com/autoconfig/" into "https://live.mozillamessaging.com/autoconfig/latte.ca", for backwards compatibility.

I haven't written any tests for it yet, largely because I want bug 534588 to land first, to do the infrastructure, but if you'ld rather I added a test, I can do that.

Thanks,
Blake.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 432619 [details] [diff] [review]
A patch to substitute in some values for tokens.

This seems to work fine, r+a=Standard8.

I'm happy to defer on the tests for a bit as we need to get this in. Please set the in-testsuite flag to '?' though.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Checked in as:
http://hg.mozilla.org/releases/comm-1.9.1/rev/a8a23224906f
http://hg.mozilla.org/comm-central/rev/ee076bd61784