552166 - Change title of empty tabs from "(Untitled)" to "New Tab"

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Markus Amalthea Magnuson]

Attachment: The "Untitled" tab and windows titles in Safari 4.0.4/Mac

No other Mac applications use parentheses in untitled titles, and Firefox shouldn't either. The Apple HIG states that untitled windows in document based applications should use "untitled" then "untitled 2", 3, 4 etc. for additional windows:

http://developer.apple.com/Mac/library/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGWindows/XHIGWindows.html#//apple_ref/doc/uid/20000961-CHDHBCGE

However, Firefox isn't _exactly_ a document based application but something inbetween, especially since there are both windows and tabs. I therefore think we should do as Safari and use "Untitled" for untitled tabs, as seen in the attached screenshot from Mac Safari 4.0.4.

Also attaching a patch to make this change.

Implementing "Untitled", "Untitled 2" etc. for additional empty windows should probably also be done, but that is a separate bug.

Comment 1

[Markus Amalthea Magnuson]

My patch needed some work, will post soon.

Comment 2

[Markus Amalthea Magnuson]

Attachment: Change empty tab title from "(Untitled)" to "Untitled" on Mac

This patch changes the title of empty tabs from "(Untitled)" to "Untitled" on Mac. If the same change is proper for all platforms, I could produce a much simpler two line-patch.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 432335 [details] [diff] [review]
Change empty tab title from "(Untitled)" to "Untitled" on Mac

Let's go with "New Tab" on all platforms.

Comment 4

[Markus Amalthea Magnuson]

Attachment: Change empty tab title from "(Untitled)" to "New Tab" on all platforms

This patch changes the empty tab title to "New Tab" on all platforms, as suggested by Alex in comment 3.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 432945 [details] [diff] [review]
Change empty tab title from "(Untitled)" to "New Tab" on all platforms

Great, to explain my rational a bit more, since the button is called "new tab" it only makes sense that the thing it creates is literally a "new tab".  Limi pointed this out awhile ago as well.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 432945 [details] [diff] [review]
Change empty tab title from "(Untitled)" to "New Tab" on all platforms

>--- a/browser/locales/en-US/chrome/browser/tabbrowser.dtd
>+++ b/browser/locales/en-US/chrome/browser/tabbrowser.dtd
>@@ -1,9 +1,9 @@
>-<!ENTITY  untitledTab            "(Untitled)">
>+<!ENTITY  untitledTab            "New Tab">

Bug 347930 removed this entity.

>--- a/browser/locales/en-US/chrome/browser/tabbrowser.properties
>+++ b/browser/locales/en-US/chrome/browser/tabbrowser.properties
>@@ -1,10 +1,10 @@
> tabs.loading=Loadingâ¦
>-tabs.untitled=(Untitled)
>+tabs.untitled=New Tab

You need to change the name for this so that localizers will pick it up.

Comment 7

[Markus Amalthea Magnuson]

Attachment: Change empty tab title from "(Untitled)" to "New Tab" on all platforms

Same patch as previously, but with the property "tabs.untitled" renamed to "tabs.emptyTabTitle" per comment 6.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 433161 [details] [diff] [review]
Change empty tab title from "(Untitled)" to "New Tab" on all platforms

r=mano

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/a34839be79aa

Comment 10

[u88484]

Verified fixed using hourly build Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100318 Minefield/3.7a4pre

with changeset http://hg.mozilla.org/mozilla-central/rev/a352d0413476

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The following Litmus tests have been updated:
https://litmus.mozilla.org/show_test.cgi?id=10076
https://litmus.mozilla.org/show_test.cgi?id=10085
https://litmus.mozilla.org/show_test.cgi?id=11347
https://litmus.mozilla.org/show_test.cgi?id=11357