552450 - Uploading beta version tells developers update is in the review queue

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[Jorge Villalobos [:jorgev] (he/him)]

A developer reported this to the amo-editors list:

Please note that the upload system in no way notified me that the file was not in the review queue.

Just the opposite, in fact -- as it told me that there were n files ahead of it in the review queue.

I did a test again today, with a test version -- and although AMO notifies me that the file has been marked as beta, AMO also says the file is in the review queue. Somebody unaware of the special designation of beta files on AMO might not understand this notice, and instead think this is a designation for files until they are reviewed -- perhaps having the AMO upload system link to the maintenance#beta-addons page you included in our correspondence might help.

>Your new version has been created and is currently marked as Beta.

> The new version will be available to the public as soon as an editor is able
> to review it. There are currently 84 other add-ons in the queue. Want to be 
> reviewed faster? Consider becoming an editor.

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

If I understand this bug right, we don't want a "this will be reviewed" message when a beta version is uploaded.

If so, this patch should suffice. It removes this message, much like we do for trusted add-on uploads.

Comment 2

[Fred Wenzel [:wenzel]]

Thanks. r65186.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Jorge: if you have time, would you mind verifying this and bug 551488?  I've tried, but whatever I'm doing this time isn't working, as I keep getting "No install.rdf present" errors, when downloading an add-on, unpacking it, revving the GUID in its install.rdf, re-zipping, and uploading it.

If not, I'll keep trying; thanks regardless.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

I might be able to help you later today, but FWIW, it sounds like you don't have the install.rdf file in the XPI root. Maybe you're compressing the whole folder, so you get ext.xpi -> folder -> install.rdf instead of ext.xpi -> install.rdf

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Verified with an alpha version of Fire.fm
https://preview.addons.mozilla.org/en-US/admin/addons?q=[7684]
There was no message saying the add-on was pending review.