Closed Bug 552758 Opened 14 years ago Closed 14 years ago

Fix browser_offline.js

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: mossop)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [rewrite])

Attachments

(1 file)

patch rev 1
4.85 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
      No description provided.
Flags: in-testsuite?
Flags: in-litmus-
Status: NEW → ASSIGNED
Fixed in http://hg.mozilla.org/projects/addonsmgr/rev/797822652673
Flags: in-testsuite? → in-testsuite+
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Blocks: 553552
Attached patch patch rev 1 — — Splinter Review 
An error crept in where occasionally loadgroup was used and sometimes loadGroup. This standardizes on loadGroup to fix the problems with some of the xpinstall browser tests.
Attachment #435764 - Flags: review?(robert.bugzilla)
Comment on attachment 435764 [details] [diff] [review]
patch rev 1

Correction, this allows cancelling a download part-way through and listens for the network going offline and cancels the download.
Attachment #435764 - Attachment description: Use consistent naming for loadGroup → patch rev 1
Attachment #435764 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
http://hg.mozilla.org/mozilla-central/rev/448fb9f286de
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
No orangeness. Marking as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: