552794 - glodacomplete needs an overhaul

Status: NEW

(Thunderbird :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

andrew comments "glodacomplete needs an overhaul" and "I think it spits out harmless errors".

for myself, I found in the error console
Error: row is undefined
Source File: chrome://gloda/content/glodacomplete.xml
Line: 88

Comment 1

[Mark Johnson]

Gloda has NEVER worked for me and finally I got round to doing something; I needed to workaround glodacomplete.xml and facet.js, as below

These are workarounds not fixes, in that I do not understand the root cause of the problem.

But Gloda now returns some results rather than just spinning forever!! yeah!

glodacomplete:
add if (!row) {} guardian around lines 88-97 inclusive

            var row = result.getObjectAt(this._currentIndex);
            if (!row) {
              var obj = row.item;
              item.setAttribute("text", trimmedSearchString);
              item.setAttribute("type", result.getStyleAt(this._currentIndex));

              item.row = row;

              // set the class at the end so we can use the attributes
              // in the xbl constructor
              item.className = "autocomplete-richlistitem";
              this.richlistbox.appendChild(item);
            } 

            this._currentIndex++;


facet.js
add try catch around line 378

        if (valId in groupMap) {
          try {
            groups[valId].push(item);
          } catch (error) {
            txt = "push error: \n pushing "
            txt += item
            txt += "\n on to "
            txt += groups[valId]
            Components.utils.reportError(txt);
          }
        }
        else {
          groupMap[valId] = val;
          groups[valId] = [item];
          this.groupCount++;
        }

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

The latter hunk suggests you have a tag named "watch".  If you remove that tag entirely, delete your global-messages-db.sqlite, and reboot, that should fix things.  We have landed some patches that improve our behaviour, but have unfortunately not fixed all the glitches.