552825 - [META] fennec - downloads - e10s

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Investigate how downloads and download progress will work in e10s.

Comment 1

[chithraprabha]

Attachment: Download Error Log

Comment 2

[chithraprabha]

Here are the logs when I try to download files.

1. Try to save/download a local file 

""" ###!!! ASSERTION: attempted to open a new window with no WindowCreator: 'mWindowCreator', file /home/chithra/E10s-Apr/electrolysis/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 678
WARNING: NS_ENSURE_TRUE(mMutable) failed: file /home/chithra/E10s-//electrolysis/netwerk/base/src/nsSimpleURI.cpp, line 149
WARNING: AsyncFaviconStep failed!: file /home/chithra/E10s/electrolysis/toolkit/components/places/src/AsyncFaviconHelpers.cpp, line 335 """

So there is problem in displaying the helperApp promt dialog, before the download would start.

2.Try to search for any pdf file using  google search, eg. 'vim pdf' and click the a link which has  pdf file and try to download the pdf file, there are some exceptions related to plugin while trying to get mime type,Logs attached in the attachment 'Download Error Log'

Comment 3

[Shawn Wilsher :sdwilsh]

I imagine we need to do some kind of remoting work on nsExternalHelperAppService.cpp.  That code should be ran in the chrome process.

Comment 5

[Egor Starkov]

What are plans about this bug? When is it going to be fixed?

Comment 6

[Juha Seppänen]

https://bugzilla.mozilla.org/show_bug.cgi?id=562444 is the actual bug where this being fixed.

Comment 8

[ahoza]

For Android build: Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100818
Namoroka/4.0b5pre Fennec/2.01apre
Device: HTC Desire A8181

the behavior is the following:


1. Go to http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-r7
2. Choose to download fennec.apk
3. Go to Options->Downloads

Results: Fennec crashes (the application is closed) when trying to open download manager

Comment 9

[ahoza]

For the same build as above:

Scenario 2:

1. Go to google.com
2. Search for resume.pdf / resume.doc and try to download a file from the result list.

Results:
User is not asked whether he wants to save the file or open it.
The content of the file is displayed directly in the browser, but obviously not in the proper format

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to comment #8)
> Results: Fennec crashes (the application is closed) when trying to open
> download manager

This has been filed as bug 588470.

Comment 11

[Brian Crowder]

Also, please file new issues as new bugs blocking this bug.  I believe your second issue is happening because we're not yet supporting content-disposition correctly.

Comment 12

[Pekka Vanhoja]

Any news on this? If I understood the code correctly all JavaScript prompts are broken in e10s. nsWebBrowser creates new nsIWindowWatcher but that new ww does not get nsIWindowCreator anywhere. I'm wondering what would be the correct path to fix this? Should Prompter start sending messages when prompts are invoked in content process, or some other approach?

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

* Downloads are currently working (bug 562444)
* Prompts from C++ should be working now too (bug 584401)

Can we close this bug?

Comment 14

[Brian Crowder]

Not sure what issues Pekka Vanhoja is still experiencing, but I think they could be tackled in follow-ups, yes.

Comment 15

[Pekka Vanhoja]

Yeah, think I was a bit hasty to jump on conclusions and saying all prompts are broken. :) They are ok in desktop fennec but in harmattan fennec they are busted for some reason. I'll continue investigating it in our env.