55292 - XBL bungles <children> insertion points that have siblings

Status: RESOLVED FIXED

(Core :: XBL, defect, P3)

Description

[David Hyatt]

Right now, <children> doesn't behave correctly when it has siblings.  It always 
puts explicit content on the end, when they could be somewhere in the middle (or 
even at the beginning).

Comment 1

[Dan Rosen]

This can be fixed by a DOM "pseudo-node" for insertion points. In conversation,
hyatt said he'll have to be careful about cloning these (for hundreds of
instantiated bindings all over the place, this could get bloaty -- maybe some
copy-on-write fun?).

Comment 2

[Peter Trudelle]

->moz0.8

Comment 3

[Peter Trudelle]

->moz0.9

Comment 4

[David Hyatt]

Attachment: Patch that cleans up insertion points and frame construction.

Comment 5

[David Hyatt]

This is stage one of a multi-stage rewrite of insertion points.  This first
stage makes insertion points with siblings operate correctly in the non-dynamic
case.  The dynamic cases (where the DOM dynamically adds/inserts kids) still fail.

Looking for an r and sr from brendan and waterson please.  Thanks guys.

Comment 6

[David Hyatt]

Attachment: A better patch that abstracts out some common code in the frame constructor.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 8

[Brendan Eich [:brendan]]

hyatt kindly walked me through the patch, and we made a few small improvements,
and something that regressed his torture test.  If I could see a new patch that
looks like what we had, but with the fix for the torture-test regression, I'll
sr= straight away.

/be

Comment 9

[David Hyatt]

Attachment: This third patch simplifies GetContentListFor and accommodates brendans corrections.

Comment 10

[Brendan Eich [:brendan]]

sr=[e-mail].

/be

Comment 11

[David Hyatt]

This is now mostly fixed.  Only remaining problems should be minor.  Still want
to clean this up before 1.0.  Moving to 0.9.

Insertion still isn't implemented right.  Append doesn't check filters.

Comment 12

[Peter Trudelle]

->moz0.8, due to dependencies.

Comment 13

[David Hyatt]

fixed now.