Closed Bug 55292 Opened 24 years ago Closed 24 years ago

XBL bungles <children> insertion points that have siblings

Categories

(Core :: XBL, defect, P3)

x86
Windows NT
defect

Tracking

()

RESOLVED FIXED
mozilla0.8

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

(Whiteboard: [xbl1.0])

Attachments

(3 files)

Right now, <children> doesn't behave correctly when it has siblings.  It always 
puts explicit content on the end, when they could be somewhere in the middle (or 
even at the beginning).
Status: NEW → ASSIGNED
Whiteboard: [xbl1.0]
This can be fixed by a DOM "pseudo-node" for insertion points. In conversation,
hyatt said he'll have to be careful about cloning these (for hundreds of
instantiated bindings all over the place, this could get bloaty -- maybe some
copy-on-write fun?).
Depends on: 59317
Blocks: 62783
->moz0.8
Target Milestone: --- → mozilla0.8
->moz0.9
Target Milestone: mozilla0.8 → mozilla0.9
This is stage one of a multi-stage rewrite of insertion points.  This first
stage makes insertion points with siblings operate correctly in the non-dynamic
case.  The dynamic cases (where the DOM dynamically adds/inserts kids) still fail.

Looking for an r and sr from brendan and waterson please.  Thanks guys.
hyatt kindly walked me through the patch, and we made a few small improvements,
and something that regressed his torture test.  If I could see a new patch that
looks like what we had, but with the fix for the torture-test regression, I'll
sr= straight away.

/be
Target Milestone: mozilla0.9 → mozilla0.8
Blocks: 67435
Blocks: 67862
This is now mostly fixed.  Only remaining problems should be minor.  Still want
to clean this up before 1.0.  Moving to 0.9.

Insertion still isn't implemented right.  Append doesn't check filters.
Target Milestone: mozilla0.8 → mozilla0.9
->moz0.8, due to dependencies.
Target Milestone: mozilla0.9 → mozilla0.8
fixed now.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: