552940 - XRemoteClient::FindBestWindow doesn't check status from XGetWindowProperty

Status: NEW

(Core :: Widget: Gtk, defect, P5)

Description

[timeless]

491  	XRemoteClient::FindBestWindow(const char *aProgram, const char 
526  	    int status = XGetWindowProperty(mDisplay, w, mMozVersionAto
530  	                                    &data_return);

this is random unless status is checked:
532  	    if (!data_return)
533  	      continue;
534  	
535  	    PRFloat64 version = PR_strtod((char*) data_return, nsnull);
536  	    XFree(data_return);

551  	        status = XGetWindowProperty(mDisplay, w, mMozProgramAtom,
555  	                                    &data_return);

this is random unless status is checked:
559  	        if (data_return) {
560  	            if (strcmp(aProgram, (const char *)data_return)) {
561  	                XFree(data_return);
566  	            XFree(data_return);

586  	        status = XGetWindowProperty(mDisplay, w, mMozUserAtom,
590  	                                    &data_return);

this is random unless status is checked:
593  	        if (data_return) {
595  	            if (strcmp(username, (const char *)data_return)) {
596  	                XFree(data_return);
600  	            XFree(data_return);

608  	        status = XGetWindowProperty(mDisplay, w, mMozProfileAtom,
612  	                                    &data_return);

this is random unless status is checked:
615  	        if (data_return) {
617  	            if (strcmp(aProfile, (const char *)data_return)) {
618  	                XFree(data_return);
622  	            XFree(data_return);

Comment 1

[timeless]

312  	XRemoteClient::CheckChildren(Window aWindow)
331  	    XGetWindowProperty(mDisplay, children[i], mMozWMStateAtom,
333  			       &nitems, &after, &data);

335  	      XFree(data);

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613