Closed
Bug 553019
Opened 14 years ago
Closed 14 years ago
In AddonInstall.onStopRequest, request.URI can be null
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: Unfocused, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
In AddonInstall.onStopRequest, request.URI can be null. There needs to be a check for this - currently when this happens, the resulting exception breaks the entire install. No idea on the specifics of when request.URI will be null.
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [rewrite]
|
Assignee | |
Comment 1•14 years ago
|
||
We have a theory for why request.URI might be undefined but not sure why it would be null. If there is a way to reproduce that it would be great as an additional testcase, otherwise http://hg.mozilla.org/projects/addonsmgr/rev/b16677de4754 should fix it anyway.
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
|
|
Reporter | |
Comment 2•14 years ago
|
||
I was sleep deprived at the time, so it's entirely possible that it was indeed undefined.
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 3•14 years ago
|
||
Landed on trunk as a part of bug 553169
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
||
Comment 4•14 years ago
|
||
Verified fixed by hg log.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•