In AddonInstall.onStopRequest, request.URI can be null

VERIFIED FIXED in mozilla1.9.3a5

Status

()

P1
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Unfocused, Assigned: mossop)

Tracking

Trunk
mozilla1.9.3a5
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rewrite])

In AddonInstall.onStopRequest, request.URI can be null. There needs to be a check for this - currently when this happens, the resulting exception breaks the entire install.

No idea on the specifics of when request.URI will be null.
Whiteboard: [rewrite]
(Assignee)

Comment 1

9 years ago
We have a theory for why request.URI might be undefined but not sure why it would be null. If there is a way to reproduce that it would be great as an additional testcase, otherwise http://hg.mozilla.org/projects/addonsmgr/rev/b16677de4754 should fix it anyway.
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
I was sleep deprived at the time, so it's entirely possible that it was indeed undefined.
(Assignee)

Updated

9 years ago
Blocks: 553169
No longer blocks: 461973
(Assignee)

Comment 3

9 years ago
Landed on trunk as a part of bug 553169
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Verified fixed by hg log.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.