Closed Bug 553090 Opened 12 years ago Closed 12 years ago

Perform update checks for installs starting from a local file

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Whiteboard: [rewrite])

Attachments

(1 file)

No description provided.
We probably already have one but a litmus test verifying that installing add-ons that need to ping AMO for a compatibility update works both from the website and from a downloaded copy of the file.

This is fixed in http://hg.mozilla.org/projects/addonsmgr/rev/a51fa458df43
Flags: in-testsuite+
Flags: in-litmus?
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-review]
Status: NEW → ASSIGNED
Attached patch patch rev 1Splinter Review
This does the compatibility update check before passing the new AddonInstall instance out to the caller.
Attachment #435785 - Flags: review?(robert.bugzilla)
Comment on attachment 435785 [details] [diff] [review]
patch rev 1

Looks good
Attachment #435785 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
http://hg.mozilla.org/mozilla-central/rev/3a1781f2c403
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Dave, for the manual test we would need something like:

1. Finding an add-on which is not compatible with the current version (e.g. take an outdated version)
2. Trying to install that add-on from the local disk
3. Trying to install that add-on from a website (should this be different from AMO?)

As result we have to check for existing updates for that add-on and install those instead?

Do we need step 2 (local disk) or is that covered by the automation script?
We do have automated tests that should cover this so maybe litmus tests for it are a low priority, but it is a case where I think the added coverage of a manual test would be useful. All your three points are right though for point 3 it can be from AMO.
verified fixed based on hg push log and passing automated tests
Status: RESOLVED → VERIFIED
(In reply to comment #6)
> We do have automated tests that should cover this so maybe litmus tests for it
> are a low priority, but it is a case where I think the added coverage of a
> manual test would be useful. All your three points are right though for point 3
> it can be from AMO.

I wouldn't target a Litmus test for this particular bug. Instead we should have a Mozmill test which automatically can make the example add-on incompatible by updating the install.rdf's maxversion entry.
Flags: in-litmus? → in-litmus?(vlad.maniac)
This manual test is kinda hard to test because it will not work with older versions of the extensions, which have been marked as compatible on AMO but not in their install.rdf file. So I'm not sure how useful this test is at the current state.

Added Litmus test:
https://litmus.mozilla.org/show_test.cgi?id=15222
Flags: in-litmus?(vlad.maniac) → in-litmus+
You need to log in before you can comment on or make changes to this bug.