553090 - Perform update checks for installs starting from a local file

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Comment 1

[Dave Townsend [:mossop]]

We probably already have one but a litmus test verifying that installing add-ons that need to ping AMO for a compatibility update works both from the website and from a downloaded copy of the file.

This is fixed in http://hg.mozilla.org/projects/addonsmgr/rev/a51fa458df43

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This does the compatibility update check before passing the new AddonInstall instance out to the caller.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 435785 [details] [diff] [review]
patch rev 1

Looks good

Comment 4

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/3a1781f2c403

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave, for the manual test we would need something like:

1. Finding an add-on which is not compatible with the current version (e.g. take an outdated version)
2. Trying to install that add-on from the local disk
3. Trying to install that add-on from a website (should this be different from AMO?)

As result we have to check for existing updates for that add-on and install those instead?

Do we need step 2 (local disk) or is that covered by the automation script?

Comment 6

[Dave Townsend [:mossop]]

We do have automated tests that should cover this so maybe litmus tests for it are a low priority, but it is a case where I think the added coverage of a manual test would be useful. All your three points are right though for point 3 it can be from AMO.

Comment 7

[raymond [:retornam] (inactive)]

verified fixed based on hg push log and passing automated tests

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)
> We do have automated tests that should cover this so maybe litmus tests for it
> are a low priority, but it is a case where I think the added coverage of a
> manual test would be useful. All your three points are right though for point 3
> it can be from AMO.

I wouldn't target a Litmus test for this particular bug. Instead we should have a Mozmill test which automatically can make the example add-on incompatible by updating the install.rdf's maxversion entry.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This manual test is kinda hard to test because it will not work with older versions of the extensions, which have been marked as compatible on AMO but not in their install.rdf file. So I'm not sure how useful this test is at the current state.

Added Litmus test:
https://litmus.mozilla.org/show_test.cgi?id=15222