553104 - Use Services.jsm in sessionstore

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I know we just made the services lazy, but now we can be even lazier and just import Services.jsm and use as many of those as we can (observer, prefs, more?). It might be appropriate to add more services to Services.jsm.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Use Services.jsm in nsSessionStartup and nsSessionStore. I didn't add any new services since it didn't seem needed.

Comment 2

[Simon Bünzli]

Comment on attachment 433627 [details] [diff] [review]
Patch v0.1

>-    shEntry.setURI(IOSvc.newURI(aEntry.url, null, null));
>+    shEntry.setURI(Services.io.newURI(aEntry.url, null, null));

While you're at it, please replace this call to newURI (and three more) with _getURIFromString, or replace _getURIFromString with Services.io.newURI, or both with NetUtil.newUri - as long as things get consistent.

Thanks and r+=me.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/mozilla-central/rev/65c44224e3cd - conformed to use _getURIFromString (Good catch by the way, I hadn't noticed that we were doing that)

Comment 4

[u279076]

What an QA do to verify this bug?

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #4)
> What an QA do to verify this bug?

Nothing really. So long as nothing has broken with those services (observers, window mediator, etc) we're fine.

Comment 6

[u279076]

Ok.  Session Store seems to work normally in today's nightly.  Marking verified.