558644 - Use Services.jsm and lazy getters in SeaMonkey sessionstore.

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

Port of "Bug 530207 - Use lazy getters for services in sessionstore" and "Bug 553104 - Use Services.jsm in sessionstore"

I ran test on my Fedora 12, no failed test seen.

Comment 1

[[e-mail]]

Comment on attachment 438344 [details] [diff] [review]
patch

I'm not a big fan of lazy getters. That NetUtil one looks particularly unobvious to me. Perhaps we can import it in writeFile instead?

Comment 2

[Misak Khachatryan]

Neil, You promised to review this by IRC.

Comment 3

[[e-mail]]

Comment on attachment 438344 [details] [diff] [review]
patch

>-Components.utils.import("resource://gre/modules/NetUtil.jsm");
Please leave NetUtil as a normal imported module. r+sr=me with this fixed.

>+XPCOMUtils.defineLazyServiceGetter(this, "CookieSvc",
>+  "@mozilla.org/cookiemanager;1", "nsICookieManager2");
I assume Firefox renamed theirs from cm/cookieManager to CookieSvc too?

>+XPCOMUtils.defineLazyServiceGetter(this, "SecuritySvc",
>+  "@mozilla.org/scriptsecuritymanager;1", "nsIScriptSecurityManager");
They're at it again. Everyone else calls it SecMan...

Comment 4

[Misak Khachatryan]

Attachment: for checking

All nits fixed, renamed CookieSvc to cm, CookieSvc to SecMan too. Carrying forward r+ and sr+ from Neil.

Comment 5

[Misak Khachatryan]

Pushed http://hg.mozilla.org/comm-central/rev/f1b0c942b792