553112 - Improved loggings for errors

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

What do you think about this as a first step (for the first trunk landing) Rob? It adds a shared logging module that all the parts use and lazily load when they first try to log. It logs out messages in the same way as the old extension manager.

I kind of want to make something all toolkit can use but maybe for now we just stick here. After the first landing I'd look at allowing exceptions and objects be passed along with the message to be included in the log output in some fashion.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 440544 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/AddonLogging.jsm b/toolkit/mozapps/extensions/AddonLogging.jsm
>new file mode 100644
>--- /dev/null
>+++ b/toolkit/mozapps/extensions/AddonLogging.jsm
>...
>+try {
>+  gDebugLogEnabled = Services.prefs.getBoolPref("extensions.logging.enabled");
>+}
>+catch (e) {
>+}
>+gDebugLogEnabled = true;
Do you really want this to always be true? Maybe for the initial landing?

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 440544 [details] [diff] [review]
patch rev 1

r=me with the above fixed per in person discussion

Comment 4

[Dave Townsend [:mossop]]

landed on branch: http://hg.mozilla.org/projects/addonsmgr/rev/c7fd38eaf53c

Comment 5

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/89c73c22d7fb

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on m-c landing.