553744 - --no-quit doesn't work when running |cfx testall| on Windows

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When I run |cfx testall| on Windows, passing it the --no-quit option, the console window showing test results disappears once the tests complete instead of staying around, which is what is supposed to happen with that option.

In case argument order matters (and since it's not clear from the docs what order they should be in), I tried both orders:

  cfx testall --no-quit
  cfx --no-quit testall

Note: I'm seeing this under MozillaBuild; I can't test in a regular console because of bug 553739.

(As an aside, it seems like --no-quit should be the default behavior on Windows, so it works the way developers expect when they run the unit tests, since it's easier for us to make sure automated continuous integration tools specify a --quit option than to educate Windows developers that they have to specify a --no-quit option.)

Comment 1

[Atul Varma [:atul]]

Attachment: patch

This seems to fix the bug on my Windows 7 machine, both from MSYS (mozilla build) and cmd.exe.

Comment 2

[Atul Varma [:atul]]

Attachment: Fixed patch to work on OS X and Windows

Comment 3

[Atul Varma [:atul]]

Myk, can you take a look at this patch and let me know if it looks ok?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The patch doesn't work as intended.  When I run |cfx testall --no-quit| with the patch applied, the console window does stay open after the tests finish running, but I don't see the window with the text "close this window to quit".

Instead, three browser windows remain open.  If I close those windows, the console window also closes.  But even then the command line doesn't return control to me.  Instead, it hangs for a while, then displays the following message before giving me another command prompt:

Traceback (most recent call last):
  File "c:/Users/myk/jetpack-sdk/bin/cfx", line 6, in <module>
    cuddlefish.run()
  File "c:\Users\myk\jetpack-sdk\python-lib\cuddlefish\__init__.py", line 216, i
n run
    test_all_packages(env_root, defaults=options.__dict__)
  File "c:\Users\myk\jetpack-sdk\python-lib\cuddlefish\__init__.py", line 177, i
n test_all_packages
    defaults=defaults)
  File "c:\Users\myk\jetpack-sdk\python-lib\cuddlefish\__init__.py", line 432, i
n run
    timeout=timeout)
  File "c:\Users\myk\jetpack-sdk\python-lib\cuddlefish\runner.py", line 144, in
run_app
    timeout)
Exception: Wait timeout exceeded (300s)

Comment 5

[Atul Varma [:atul]]

Are you using Windows 7, or a different OS?  And which version of Firefox/Thunderbird/XULRunner SDK are you using?

I think I verified this working on Windows 7 w/ Firefox 3.5 or 3.6, but I suspect it may not work on different versions of the platform.

Comment 6

[Atul Varma [:atul]]

I've just created bug 554241, which can be used to make Windows' cfx behavior look just like os x and linux behavior, obviating the need for the --no-quit option altogether.  See the bug for more information.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #5)
> Are you using Windows 7, or a different OS?  And which version of
> Firefox/Thunderbird/XULRunner SDK are you using?

Windows 7 with Firefox 3.6 (Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6).

Comment 8

[Atul Varma [:atul]]

Ok, since bug 554241 is resolved and cfx works on Windows just like it does on other platforms, I'm marking this bug as WONTFIX. It's basically being superseded by bug 554720, "Remove --no-quit option from cfx".

Comment 9

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".