553775 - Make plugins.css use sane colors

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

philor reminded me today that bug 377325 has gone nowhere in the three years since I filed it.  We should just make plugins.css sane on our own.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Note to self: when we land this in cm192test, the pinstripe manifest needs to put the file in content, because this file is dumb (see bug 328678 comment 4 for why it's dumb).

Comment 2

[philippe (part-time)]

Attachment: make about:plugins pretty v1

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 433881 [details] [diff] [review]
make about:plugins pretty v1

A couple of things here:

1) I don't think we can land this on 1.9.0 as-is because of the word-wrap issue; having that run into the other column is worse than the ugly colors on 1.9.0.

1a) To land this on 1.9.0, it would need to live at embed-replacements/content/global/plugins.css for the same reason as comment 1; otherwise we inherit some ugly styles (e.g. the title font) from the core file.

2) I'd really like to see the extra spacing between "Version" ("Name" in 1.9.0, since "Version" is missing) and the line/paragraph of descriptive text that follows; that seems to be missing in this patch.

Comment 4

[philippe (part-time)]

(In reply to comment #3)
 
> 1) I don't think we can land this on 1.9.0 as-is because of the word-wrap
> issue; having that run into the other column is worse than the ugly colors on
> 1.9.0.
Without the word-break property, those long strings won't wrap. I can make the table expand as needed in that case; however, at narrow window width (< 700px), the QuickTime table will overflow the body.
http://dev.l-c-n.com/camino/qtoverflow.png
Two options for 1.9.0:
1. let the table expand as needed and overflow the border.
2. do without some of the 'about' styling (mostly: frame around body)
http://dev.l-c-n.com/camino/plugins-css-1.9.0.png

> 1a) To land this on 1.9.0, it would need to live at
> embed-replacements/content/global/plugins.css for the same reason as comment 1;
> otherwise we inherit some ugly styles (e.g. the title font) from the core file.

Ok, my bad, I misunderstood how the whole thing passes through the build scripts. Moved.
 
> 2) I'd really like to see the extra spacing between "Version" ("Name" in 1.9.0,
> since "Version" is missing) and the line/paragraph of descriptive text that
> follows; that seems to be missing in this patch.

Uh, it should have been there. Stupid typo. Fixed

Comment 5

[philippe (part-time)]

Per IRC discussion, going option 1. in comment 4.

I've add a little hack in the stylesheet to give Camino-Gecko 1.9.0 users a decent experience while having a more optimal look for Camino-Gecko 1.9.2.

Basically: Camino-Gecko 1.9.0 users will have a border on the table cells (to compensate for lack of nth-child() support), and will have to do with an expanding table on narrow windows. A media query (not supported by Gecko 1.9.0) is used as filter to give Gecko 1.9.2 users a better experience. This litte hack can be removed once we're safely on Camino-Gecko 1.9.2 - and is noted in a comment in the stylesheet.

(Once we're safely on Camino-Gecko 1.9.2, I'd like to do some small polish surgery on all those about-* stylesheets anyway - something that cannot be done while sharing with 1.9.0)

Comment 6

[philippe (part-time)]

Attachment: make about:plugins pretty v2

v2 - fixes the stupid typo, moves the file to /camino/embed-replacements/content/global and fixes the display issues for Camino-Gecko1.9.0

Comment 7

[philippe (part-time)]

Attachment: make about:plugins pretty v2.1

correcting an oopsie. Sorry about that.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 434428 [details] [diff] [review]
make about:plugins pretty v2.1

r=ardissone

about:plugins looks MUCH better!

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: 1.9.2 packaging change

Stuart, this is the packaging change we'll need on 1.9.2 to pack the file.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 434432 [details] [diff] [review]
1.9.2 packaging change

Eh, there's a missing 's' in that comment; fixed locally.

Comment 11

[Stuart Morgan]

Screenshot?

Also, is there a reason we don't just do different 1.9.2 and 1.9.0 patches?

Comment 12

[philippe (part-time)]

(In reply to comment #11)
> Screenshot?

http://dev.l-c-n.com/camino/g19x/plugins-camino1.9.0.png
http://dev.l-c-n.com/camino/g19x/plugins-camino1.9.2.png

> Also, is there a reason we don't just do different 1.9.2 and 1.9.0 patches?

I understood smokey prefers one patch (?).

Comment 13

[philippe (part-time)]

(In reply to comment #12)
> (In reply to comment #11)
> > Screenshot?
> 
> http://dev.l-c-n.com/camino/g19x/plugins-camino1.9.0.png

better
http://www.ardisson.org/smokey/moz/camino-plugins-1.9.0.png

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

> > Also, is there a reason we don't just do different 1.9.2 and 1.9.0 patches?
> 
> I understood smokey prefers one patch (?).

I guess at this point we're treating the 1.9.2 test repo as a "real" repo, so we could do that.  

In terms of keeping what we land on cvs easily mergeable with the stuff in Hg during this period, though, generally speaking, it's saner the other way, though in this particular case (adding a new file), I guess it doesn't matter.

Comment 15

[philippe (part-time)]

Attachment: plugins.css for Gecko 1.9.2

patch for Camino -gecko1.9.2

Comment 16

[philippe (part-time)]

Attachment: plugins.css for Gecko 1.9.0

for Camino Gecko 1.9.0

Comment 17

[Stuart Morgan]

Comment on attachment 434466 [details] [diff] [review]
plugins.css for Gecko 1.9.2

sr=smorgan. This is at least 700% better than the current look.

Comment 18

[Stuart Morgan]

Comment on attachment 434432 [details] [diff] [review]
1.9.2 packaging change

sr=smorgan

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Now at least 700% better on cvs trunk and in the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/b808bf14ed8d and http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/14484fa615f4

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/23441c950734 (css) and 
http://hg.mozilla.org/camino/rev/33190e1e25ee (packaging)