Closed
Bug 553790
Opened 15 years ago
Closed 15 years ago
XPIProvider.getInstalls() does not filter by type
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: Unfocused, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
|
2.05 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
XPIProvider.getInstalls() ignores the types argument, therefore the resulting array is not filtered by type.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-review]
|
|
Assignee | |
Comment 2•15 years ago
|
||
Implements filtering installs by type and tests that it works
Attachment #435768 -
Flags: review?(robert.bugzilla)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 435768 [details] [diff] [review]
Filter getInstalls by type
Looks good but I think it should be called getInstallsByTypes
Attachment #435768 -
Flags: review?(robert.bugzilla) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
|
|
Assignee | |
Comment 4•15 years ago
|
||
Going to take care of renaming the method in bug 555942
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
||
Comment 6•15 years ago
|
||
Verified fixed by hg log. That function has been renamed to getInstallsByTypes meanwhile.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•