Closed Bug 553790 Opened 14 years ago Closed 14 years ago

XPIProvider.getInstalls() does not filter by type

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: Unfocused, Assigned: mossop)

References

Details

(Whiteboard: [rewrite])

Attachments

(1 file)

Filter getInstalls by type
2.05 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
XPIProvider.getInstalls() ignores the types argument, therefore the resulting array is not filtered by type.
http://hg.mozilla.org/projects/addonsmgr/rev/c1aee42d22d2
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-review]
Implements filtering installs by type and tests that it works
Attachment #435768 - Flags: review?(robert.bugzilla)
Comment on attachment 435768 [details] [diff] [review]
Filter getInstalls by type

Looks good but I think it should be called getInstallsByTypes
Attachment #435768 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
Going to take care of renaming the method in bug 555942
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
http://hg.mozilla.org/mozilla-central/rev/a5b24ddb33c3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Verified fixed by hg log. That function has been renamed to getInstallsByTypes meanwhile.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: