553858 - onDownloadEnded is fired after onInstallEnded

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

When installing a new addon, the following events are typically triggered:
onNewInstall, onDownloadStarted, onDownloadProgress, onDownloadProgress, onInstallStarted, onInstalling, onInstallEnded, onDownloadEnded

Note that onDownloadEnded is fired last - I would expect it to be fired after the last onDownloadProgress, and before onInstallStarted.

Comment 1

[Dave Townsend [:mossop]]

Is this still happening, the tests aren't seeing that.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yea, still happening. As far as I can tell:

* downloadComplete() is called at the right time, which calls callInstallListeners() for onDownloadEnded
* As callInstallListeners() is iterating through the listeners, one of them starts the install
* Starting the install immediately triggers onInstallStarted/onInstalling/onInstallEnded
* callInstallListeners() keeps iterating through the rest of the listeners, for onDownloadEnded
* The UI registered as an install listener last, so is always held up by some other listener starting the install before the UI gets its onDownloadEnded event

I suspect (but haven't confirmed) the rogue listener is the WebInstallListener.

Comment 3

[Dave Townsend [:mossop]]

Ah, hmm that makes sense. It probably would be WebInstallListener too.

Comment 4

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.