Closed
Bug 553872
Opened 15 years ago
Closed 15 years ago
Addon.pendingOperations doesn't indicate PENDING_INSTALL when upgrade requires restart
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: Unfocused, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
|
5.05 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Addon.pendingOperations doesn't indicate PENDING_INSTALL when an upgrade has been installed and requires a restart.
Specifically, this is because the check in the pendingOperations getter only checks if the addon exists in the database (and is therefore a new install).
|
Assignee | |
Comment 1•15 years ago
|
||
I've added a PENDING_UPGRADE bit on the rationale that we have two Addon instances here, one is installed and will be replaced on the next restart which is PENDING_UPGRADE, the other is waiting to replace it on the next restart, that is PENDING_INSTALL. I've also added the pendingUpgrade property to return the Addon that will replace the Addon on the next restart.
http://hg.mozilla.org/projects/addonsmgr/rev/a029ad469828
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-review]
|
|
Assignee | |
Comment 2•15 years ago
|
||
Adds the PENDING_UPGRADE bit and the pendingUpgrade property.
Attachment #435795 -
Flags: review?(robert.bugzilla)
|
||
Updated•15 years ago
|
Attachment #435795 -
Flags: review?(robert.bugzilla) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
||
Comment 4•15 years ago
|
||
Verified fixed by check-in. This function has been moved to XPIProvider.jsm meanwhile.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•