553949 - Stop showing environment variables in every script phase

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix, v1.0

Bug 553743 Comment 3 Smokey Ardisson (no bugmail - do not email)      2010-03-20 21:15:37 PDT

(From update of attachment 433776 [details] [diff] [review])
Also, I noticed when changing this that there's a checkbox to suppress showing
the miles of environment variables for script phases.

Can we dispense with that in all our script phases?  If we ever need to debug
the script phases that use them, it's easy enough to turn them back on, and in
the meantime it saves tons of lines of scrollback/tinderbox logs.

Bug 553743 Comment 5 Stuart Morgan 2010-03-20 21:39:47 PDT

(In reply to comment #3)
> Can we dispense with that in all our script phases?

Fine by me, especially since we don't do much fancy stuff with environment
variables in our scripts anyway. Although it might be good to leave it on for
one script phase, so we have one copy of all the variables for reference; your
call.

---

This patch dispenses with all of the env var spamming except for the very first shell script phase in each target ("Copy Crash Reporter InfoPlists.strings Override" in the Camino*App targets, and "Change Sparkle Load Path" in General.prefPane).

It applies on both cvs branches, and on hg with a s/Embed/bin/g in Hunk 3; I'd like to land it on all three.

Comment 1

[Stuart Morgan]

Comment on attachment 433845 [details] [diff] [review]
Fix, v1.0

sr=smorgan

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk, CAMINO_2_0_BRANCH, and pushed to the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/0ae3babc08c7

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/8ed7eafe702c