553956 - AddonProviders that contain syntax errors can break everything

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Dave Townsend [:mossop]]

Already fixed but want a bug for review purposes: http://hg.mozilla.org/projects/addonsmgr/rev/8c757fa5c3ab

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple fix to ensure that importing a file with a syntax error doesn't harm the manager.

Comment 2

[Dave Townsend [:mossop]]

Landed:

http://hg.mozilla.org/mozilla-central/rev/09553c7137f9

No easy way to automatically or manually test this but it is simple enough.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

> ERROR("Exception loading provider \"" + url + "\": " + e);

Dave, shouldn't we better throw an exception in the Error Console under such a situation? Only dumping a debug message if we fail to load a provider doesn't seem to be enough IMO.

Comment 4

[Dave Townsend [:mossop]]

The ERROR function does log to the error console and puts a message into extensions.log in the profile folder.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100515 Minefield/3.7a5pre GTB7.1 ID:20100515040001

Thanks for the explanation Dave. I have tested it with creating a syntax error in XPIProvider.jsm and the result is written as an error to the Error Console and into the extension.log.