554118 - Make the name of tabs independent of the channel name

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[Will Pittenger]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 GTB6 (.NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
Build Identifier: ChatZilla 0.9.86-rdmsoft [XULRunner 1.9.0.11/2009060313

The idea is that instead of a long name taking up a lot of space, I could have a short name when I need the horizontal space.  So "commons" would replace something like #wikimedia-commons.

Reproducible: Always

Steps to Reproduce:
1.Open a lot of tabs whose channels have long names like #wikimedia-commons.
2.Soon CZ shortens tabnames to make room.
3.Eventually, it becomes unclear which is which.
Actual Results:  
Tab names become unreadable quickly.

Expected Results:  
Users could specify a shorter name to conserve space.

Please note that while I listed x86_64 as my platform, that is only my version of Windows.  I use a 32-bit CZ build.

Comment 1

[Mardeg]

Manual workaround mentioned on IRC, needs you to be on the channel already:

/evals getTabForObject(this).label = "#FOO"

Comment 2

[Tony Mechelynck [:tonymec]]

IMHO this would be "nice to have" on any platform; especially if we could also have the full original name of the (client, server, query or channel) tab in a tooltip shown onmouseover.

Hm, in the light of comment #1, maybe
    /alias rename evalsilent getTabForObject(this).label = "$(1)"
(or some such) as the manual solution? Doesn't give me a tooltip, of course, but otherwise it works.
Usage:
    /rename <new-name>
changes the name displayed on the current tab.

Comment 3

[:Gijs (he/him)]

Attachment: Simple patch

It's been ages since I did this, but from what I can tell, this should be enough to satisfy the needs of the reporter...

Comment 4

[:Gijs (he/him)]

Attachment: Patch with the menu support actually there

D'oh.

Comment 5

[Will Pittenger]

One thing I just thought of, make this a preference for the channel.  That way, CZ remembers the override.

Comment 6

[Samuel Sieb]

Comment on attachment 540236 [details] [diff] [review]
Patch with the menu support actually there

Did you attach the jar file instead of the patch?

Comment 7

[:Gijs (he/him)]

Attachment: Patch for real [checked in]

Hmm, I totally blame session restore for not remembering files correctly. I'll have to see if I can reproduce that. It's the XPI, for what it's worth. Also, it's not a preference yet. Which may make sense, but is somewhat harder to do - do all kinds of views have associated prefs? What about eg. DCC views?

Comment 8

[Tony Mechelynck [:tonymec]]

See bug 671158 for a different proposed solution to the problem of having more tabs (and with long names) than can fit on the screen width.

Comment 9

[James Ross]

Comment on attachment 540312 [details] [diff] [review]
Patch for real [checked in]

Review of attachment 540312 [details] [diff] [review]:
-----------------------------------------------------------------

::: xul/content/commands.js
@@ +1732,5 @@
> +    if (!label) {
> +        return;
> +    }
> +    tab.label = label;
> +    tab.setAttribute("tooltiptext", e.sourceObject.unicodeName);

As you're not persisting the name elsewhere or otherwise modifying the relevant code, the rename will be lost on user tabs when the user changes nick, I expect. A minor issue, though, considering the intended use of this command.

Comment 10

[:Gijs (he/him)]

http://hg.mozilla.org/chatzilla/rev/a8646d30fd33

Leaving open to decide if this needs a preference. Unassigning because I don't know if/when I will work on that.

Comment 11

[Robert Kaiser]

Just FYI, as no chatzilla release has been made since, we are still not shipping this change in SeaMonkey.

Comment 12

[Tony Mechelynck [:tonymec]]

(In reply to Robert Kaiser (:[e-mail]) from comment #11)
> Just FYI, as no chatzilla release has been made since, we are still not
> shipping this change in SeaMonkey.

except, of course, in trunk (currently 2.14a1) which always ships with whatever was at the tip of the "default" branch of the ChatZilla repository at the time the SeaMonkey build was started. I'm not sure which cZ version ships with SeaMonkey 2.13a2 Aurora.

Comment 13

[Tony Mechelynck [:tonymec]]

P.S. Yet I don't see that menuitem when right-clicking a tab, and also not on the main menubar, and "/help label" gives me an error: «The command “label” is not known to ChatZilla.». Of course, the alias in comment #2, and the equivalent manual workaround in comment #1, still work.

Using:
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Firefox/17.0 SeaMonkey/2.14a1 ID:20120721003003 CSet: ec138f1fcabf m-c: 045c11dd41a6
ChatZilla 0.9.88.2, last updated on: 17 May 2012

Comment 14

[Tony Mechelynck [:tonymec]]

OOps... After reinstalling cZ from <appdir>/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi the menuitem does appear.

Comment 15

[Tony Mechelynck [:tonymec]]

Gijs: I suggest marking this bug as FIXED (if you do, I'll VERIFY it). A possible preference can be the subject of a followup bug if anyone thinks it useful.

Comment 16

[Tony Mechelynck [:tonymec]]

(In reply to Tony Mechelynck [:tonymec] from comment #14)
> OOps... After reinstalling cZ from
> <appdir>/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
> the menuitem does appear.

... and the command (which is /rename, not /label as I erroneously thought in comment #13) still exists after undefining the alias in comment #2

Comment 17

[Robert Kaiser]

(In reply to Tony Mechelynck [:tonymec] from comment #12)
> except, of course, in trunk (currently 2.14a1) which always ships with
> whatever was at the tip of the "default" branch of the ChatZilla repository
> at the time the SeaMonkey build was started. I'm not sure which cZ version
> ships with SeaMonkey 2.13a2 Aurora.

Sure, SeaMonkey trunk comes with ChatZilla trunk. Aurora and up ship the latest actual release of ChatZilla, which doesn't have this patch (which makes L10n somewhat of a pain as we need to back out patches when uplifting from trunk to aurora).

Comment 18

[:Gijs (he/him)]

Attachment: make labels a pref,

So, this corrects the formatting to the CZ standard, and moves it all into a pref. It also fixes bug 810281 and bug 850314, obviously. It doesn't fix bug 813422 because that's got to do with some weirdness in how we handle 'end of who' messages, it seems.

Comment 19

[:Gijs (he/him)]

http://hg.mozilla.org/chatzilla/rev/a2d6b97e43e5