554220 - Persona Editor - not closing or applying custom Persona in Firefox 3.6.2

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Ken Saunders]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 WebSlideShow/1.4.0
Build Identifier: Personas 1.5.2

The Persona Editor (chrome://personas/content/customPersonaEditor.xul) is not closing after hitting OK, and is not applying custom Personas when hitting OK then manually closing the editor.
The custom Persona (preview) does load and display properly.

This issue does not exist with Personas 1.5.2 in Thunderbird 3.0.3, or Firefox 3.5.8. I don't remember it occurring in 3.6.



Reproducible: Always

Steps to Reproduce:
1. Personas menu > Custom Persona > Edit 
2. Load a Persona header, footer, or just change the text color
3. Click OK
Actual Results:  
Persona Editor (tab) does not close.
Custom Persona is not applied.

Expected Results:  
Custom Persona Editor tab should close on apply (OK)
Custom Persona should be applied after clicking OK

Comment 1

[Ken Saunders]

It appears that others are now experiencing the same issue.
Perhaps due to the fact that Firefox 3.6.2 has now been released?

Sorry for the lack of technical terms and details (actual code), but the following reports sound like they have something to do with the edit Custom Persona preview time settings where the Persona that's currently in use/applied is returned to view if a custom Persona is not applied within x amount of time.

The user can load their custom Persona, and it's displayed properly, but it is not applied when they hit OK, the preview time expires and Personas Plus defaults back to the Persona that was applied before opening up the Custom Persona editor.

In my opinion, it has nothing to do with the preview time, it's the custom Persona not being applied that is the issue.

Personas doesn't work: can't save my own persona 
http://xrl.in/4ved
My personnal Personnas don't stay active !
http://xrl.in/4vef

Comment 2

[Ryan Doherty (:rdoherty)]

Thank Ken! We'll try to get a fix for this into a release soon.

Comment 3

[Ken Saunders]

Should the importance of this bug be raised? Does that matter anyway (I'm still green to Bugzilla)?

Aside from Personas designers having the ability to preview their work before uploading it (which is still fully functional), I believe that Personas Plus's greatest appeal and benefit to users is being able to apply custom Personas without any restrictions (size, content, etc).
It currently feels like half an add-on or a lite one with a premium feature partially enabled.

Comment 4

[Ryan Doherty (:rdoherty)]

Importance bumped up, will bundle this in an update to personas plus soon.

Comment 5

[Shae Rivard [:crimius]]

confirmed in FF 3.6 under Mac OSX as well.  it seemed to change when he moused over the New tab button.

Comment 6

[Shae Rivard [:crimius]]

A user also reported this Error in the Error Console:

Error: uncaught exception: 2147942487

Comment 7

[James Von Hendy]

uncaught exception: 2147942487

Operating System: Windows XP Professional, SP3

Firefox 3.6.2

(in case platform info helps)

Comment 8

[Ian B.]

To add, the persona does preview for about 15 seconds before reverting to the previous theme, though it does not apply when the "apply" button is pressed.

OS: Windows Vista SP2

Firefox: 3.6.2

Comment 9

[jvalentine]

I too have been able to reproduce this error in Mac OSX on the latest version of Firefox.  The persona will stay selected for about 15 seconds.  It doesn't appear to be related to mousing over anything on the screen.

Comment 10

[Jose E. Bolanos]

I found out that the Persona code exits when it tries to set the custom persona using the LightweightThemeManager:

service.js, line 651:
LightweightThemeManager.currentTheme = aPersona;

The Error Console shows the following error, thrown when the previous line is executed:
Error: uncaught exception: 2147942487

I checked the custom persona JSON code and everything seems to be OK. The id, name, and headerURL fields (which are mandatory) are being passed correctly:

{"id":0,"name":"Custom Persona","headerURL":"file:///Users/josenriq/Pictures/vista%20aparta/en%20el%20dia.JPG?4871","footerURL":"file:///Users/josenriq/Pictures/vista%20aparta/IMG_1529%20(1).jpg?9844","custom":true,"textcolor":"#333333","accentcolor":"#FF0000"}

It seems like something changed inside the LightweightThemeManager for 3.6.2 which is causing this issue.

Comment 11

[Ryan Doherty (:rdoherty)]

Dao, can you take a look at comment 10? Wondering if there's a workaround on our end so we can fix it by releasing a fix to the Personas Plus add-on.

Comment 12

[Ken Saunders]

Hey I just replaced 3.6.2's LightweightThemeConsumer.jsm and LightweightThemeManager.jsm with 3.6's and Personas Plus is working fine again.

I'll leave it up to you all that really knows why that worked because I still haven't even mastered CSS.

Of course 3.6.2's, and 3.6's files could be compared for changes/differences, but I wouldn't know what to do with the info, plus, if there even were major changes made to one of those files (I'm guessing it's LightweightThemeManager), were they security related ones?

Comment 13

[Ken Saunders]

Should have been more specific.
C:\Program Files\Mozilla Firefox 3.6\modules\LightweightThemeConsumer.jsm
C:\Program Files\Mozilla Firefox 3.6\modules\LightweightThemeManager.jsm

Comment 14

[Ken Saunders]

Attachment: Firefox 3.6 - 3.6.2 LightweightThemeManager.jsm Comparison

I hope that this is helpful

Comment 15

[James Von Hendy]

(In reply to comment #14)
> Created an attachment (id=435274) [details]
> Firefox 3.6 - 3.6.2 LightweightThemeManager.jsm Comparison
> 
> I hope that this is helpful

Thanks Ken, both for the compare and for pointing at what works (restoring the 3.6 versions of LightWeightThemeConsumer.jsm and LightWeightThemeManager.jsm).

Yep, from the compares it looks like one of the try...catch handlers is getting tripped every time in the 3.6.2 code.

When I installed 3.6.2 the installer overwrote my 3.6 files. Sure wish I had the 3.6 jsm files to slip in as you did!

James

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #10)
> I checked the custom persona JSON code and everything seems to be OK. The id,
> name, and headerURL fields (which are mandatory) are being passed correctly:
> 
> {"id":0,

The id is expected to be a string.

Comment 17

[Ken Saunders]

Well, there is obviously a reason why changes were made to the LightweightThemeManager.jsm and with me being oblivious to the reasons, or being able to understand the code, I'm not sure if it was security related or not so I don't want to attach the file here, but here's how I got it.
Downloaded 3.6 (http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.6/)
Opened Firefox Setup 3.6.exe with 7-Zip > nonlocalized > modules, grabbed LightweightThemeManager.jsm and moved it to C:\Program Files\Mozilla Firefox 3.6\modules.
I made a backup of 3.6.2's LightweightThemeManager.jsm first.

Comment 18

[James Von Hendy]

(In reply to comment #17)
> Well, there is obviously a reason why changes were made to the
> LightweightThemeManager.jsm and with me being oblivious to the reasons, or
> being able to understand the code, I'm not sure if it was security related or
> not so I don't want to attach the file here, but here's how I got it.
> Downloaded 3.6
> (http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.6/)
> Opened Firefox Setup 3.6.exe with 7-Zip > nonlocalized > modules, grabbed
> LightweightThemeManager.jsm and moved it to C:\Program Files\Mozilla Firefox
> 3.6\modules.
> I made a backup of 3.6.2's LightweightThemeManager.jsm first.

Thanks Ken! You're a good man! And yes, I would do exactly the same thing: make a backup of the 3.6.2 files and also be aware that given the scope of changes, they were intentional.... In the meantime, we can play if we want to!

Thanks again!

James

Comment 19

[Tom Noiprasit]

(In reply to comment #17)
> Well, there is obviously a reason why changes were made to the
> LightweightThemeManager.jsm and with me being oblivious to the reasons, or
> being able to understand the code, I'm not sure if it was security related or
> not so I don't want to attach the file here, but here's how I got it.
> Downloaded 3.6
> (http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.6/)
> Opened Firefox Setup 3.6.exe with 7-Zip > nonlocalized > modules, grabbed
> LightweightThemeManager.jsm and moved it to C:\Program Files\Mozilla Firefox
> 3.6\modules.
> I made a backup of 3.6.2's LightweightThemeManager.jsm first.

Thank you, Ken. It works well on mine, too. Just a note for Ubuntu's fans:

"C:\Program Files\Mozilla Firefox 3.6\modules" is translated to 
,depending on your firefox versions in Ubuntu, but normally,
/usr/lib/firefox/modules

Comment 22

[TAZmd]

Thanks Ken.

Before your fix i had to keep changing "lightweighttheme-footer" "lightweighttheme-header" files in C:\Documents and Settings\User\Application Data\Mozilla\Firefox\Profiles folder

Hope they fix it soon with an update.

Comment 23

[Ryan Doherty (:rdoherty)]

TAZmd: don't know how/why you did it, but you removed everyone from the cc list.

Comment 24

[atanok]

Bug reproducible in x86 Linux, too.

Ubuntu 8.10, Firefox 3.6.2, Personas 1.5.2.

Comment 25

[Anael Grailkeeper]

Not sure if this is pertinent to the bug, but the file "chrome://personas/content/init.js" is refered in "customPersonaEditor.xul", but is not present in the "chrome.jar" file.

Comment 26

[Jose E. Bolanos]

I just checked and it does not work passing the id as a string either. The same exception is thrown.

{"id":"0",
"name":"Custom Persona",
"headerURL":"file:///Users/josenriq/Pictures/vista%20aparta/en%20el%20dia.JPG?1822",
"footerURL":"file:///Users/josenriq/Pictures/vista%20aparta/IMG_1511.JPG?585",
"custom":true}

Comment 27

[Ryan Doherty (:rdoherty)]

Moving to Firefox, looks like we can't fix this on the add-on side.

Comment 28

[Dão Gottwald [:dao]]

(In reply to comment #26)
> I just checked and it does not work passing the id as a string either. The same
> exception is thrown.
> 
> {"id":"0",
> "name":"Custom Persona",
> "headerURL":"file:///Users/josenriq/Pictures/vista%20aparta/en%20el%20dia.JPG?1822",
> "footerURL":"file:///Users/josenriq/Pictures/vista%20aparta/IMG_1511.JPG?585",
> "custom":true}

The next issue is that URLs are expected to be http or https.

By the way, Firefox:Theme is for everything under <http://mxr.mozilla.org/mozilla-central/source/browser/themes/>, i.e. very likely not the right component for this.

Comment 29

[Ryan Doherty (:rdoherty)]

(In reply to comment #28)
> > {"id":"0",
> > "name":"Custom Persona",
> > "headerURL":"file:///Users/josenriq/Pictures/vista%20aparta/en%20el%20dia.JPG?1822",
> > "footerURL":"file:///Users/josenriq/Pictures/vista%20aparta/IMG_1511.JPG?585",
> > "custom":true}
> 
> The next issue is that URLs are expected to be http or https.

Ok, are there more issues or is this it? Is there any way to load a local file?

> By the way, Firefox:Theme is for everything under
> <http://mxr.mozilla.org/mozilla-central/source/browser/themes/>, i.e. very
> likely not the right component for this.

Is there a component that is appropriate? I'm not familiar enough with the Firefox codebase to know where issues with Lightweight themes should go.

Comment 30

[Dão Gottwald [:dao]]

(In reply to comment #29)
> > The next issue is that URLs are expected to be http or https.
> 
> Ok, are there more issues or is this it?

Well, I don't know, as "uncaught exception: 2147942487" doesn't tell me anything. I'm only pointing out the issues I happen to spot myself.

> Is there any way to load a local file?

Not with LightweightThemeManager.jsm's pseudo API.

> Is there a component that is appropriate? I'm not familiar enough with the
> Firefox codebase to know where issues with Lightweight themes should go.

If you want LightweightThemeManager.jsm to change (e.g. accept file URIs), Toolkit:Add-ons Manager would be the best bet.

Comment 31

[atanok]

>The next issue is that URLs are expected to be http or https.

That's not the problem, really.
In my case, I was entering http addresses manually instead of clicking "Browse..." and picking a local file.

This because I made the files on another local computer and had it host them through http, instead of copying them over.

Regardless, even if you only change the font color without entering any pictures, it reverts back to whatever it was using before, so it's not that kind of problem.

Comment 32

[Dão Gottwald [:dao]]

(In reply to comment #31)
> >The next issue is that URLs are expected to be http or https.
> 
> That's not the problem, really.
> In my case, I was entering http addresses manually instead of clicking
> "Browse..." and picking a local file.
> 
> This because I made the files on another local computer and had it host them
> through http, instead of copying them over.
> 
> Regardless, even if you only change the font color without entering any
> pictures, it reverts back to whatever it was using before, so it's not that
> kind of problem.

I suspect you're still suffering from the id not being a string.

Comment 33

[Ryan Doherty (:rdoherty)]

Can anyone on the Firefox team take a look at this and provide details? The Personas support forum, google group and email address continually receives users complaining about this functionality breaking. 

My only option right now is to recommend users downgrade to Firefox 3.6.

Comment 34

[Dave Townsend [:mossop] (PTO until Aug 21st)]

(In reply to comment #33)
> Can anyone on the Firefox team take a look at this and provide details? The
> Personas support forum, google group and email address continually receives
> users complaining about this functionality breaking. 

Dão has already pointed out that the ID must be a string and the headerURL must be http or https. If either of these are not the case then setting LightweightThemeManager.currentTheme will throw error 2147942487 (NS_ERROR_INVALID_ARG). If the footerURL is not http or https then it will be silently ignored.

Comment 35

[Ryan Doherty (:rdoherty)]

(In reply to comment #34)
> Dão has already pointed out that the ID must be a string and the headerURL must
> be http or https. If either of these are not the case then setting
> LightweightThemeManager.currentTheme will throw error 2147942487
> (NS_ERROR_INVALID_ARG). If the footerURL is not http or https then it will be
> silently ignored.

Thanks Dave, will file a separate bug.

Comment 36

[Ken Saunders]

Since users using 3.6 puts them at enough risk for the German government to tell people not use 3.6 (which the media flooded the Internet with), and the "critical security issue" forced Mozilla to push 3.6.2 a little early, can someone at a minimum take a look at comments 12 and 17 and let us know if that is a safe fix for now?

Personas Plus
Active Daily Users
On Tuesday, Mar. 30
3,955,083

(In reply to comment #12)
> Hey I just replaced 3.6.2's LightweightThemeConsumer.jsm and
> LightweightThemeManager.jsm with 3.6's and Personas Plus is working fine again.

(In reply to comment #17)
> Well, there is obviously a reason why changes were made to the
> LightweightThemeManager.jsm and with me being oblivious to the reasons, or
> being able to understand the code, I'm not sure if it was security related or
> not so I don't want to attach the file here, but here's how I got it.
> Downloaded 3.6
> (http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.6/)
> Opened Firefox Setup 3.6.exe with 7-Zip > nonlocalized > modules, grabbed
> LightweightThemeManager.jsm and moved it to C:\Program Files\Mozilla Firefox
> 3.6\modules.
> I made a backup of 3.6.2's LightweightThemeManager.jsm first.

Comment 37

[Ryan Doherty (:rdoherty)]

Filed bug 556334

Comment 38

[Scott Finnell]

This bug has not been fixed in the last update to Firefox, does anyone know when this particular bug is going to be fixed. I rolled back to 3.6. because I could not design new Personas to upload to the persona web page.  It has not been fixed in 3.6.2 or 3.6.3. I believe those are the editions. There is a lot of chatter about it, but no real fixes that a layman can understand. I recommended to everyone to roll back, but is this a safe thing to do?

Comment 39

[Dão Gottwald [:dao]]

No, downgrading is not safe, as the 3.6.2 and 3.6.3 updates contained security fixes.

Comment 40

[Dão Gottwald [:dao]]

I'm adding a currentThemeWithLocalResources setter in bug 556334. Assuming it gets reviewed, Personas will need to use this instead of currentTheme when applying the custom persona.

Comment 44

[Shae Rivard [:crimius]]

Are we just waiting on implementation of the fix in bug 556334 into a stable release to mark this bug as resolved?

Comment 45

[Ryan Doherty (:rdoherty)]

(In reply to comment #44)
> Are we just waiting on implementation of the fix in bug 556334 into a stable
> release to mark this bug as resolved?

This will also require a small add-on change to use the new API created from bug 556334. I'll work with AppCoast to get the fix in.

Comment 47

[John Kearney]

Just pointing out that "%bindir%\modules\LightweightThemeConsumer.jsm" isn't changed between 3.6.0 and 3.6.2 - only "%bindir%\modules\LightweightThemeManager.jsm" changes between the two builds.

Comment 48

[Dave]

Just downloaded 3.6.4 and still no fix, very dissappointed

Comment 49

[Ken Saunders]

(In reply to comment #48)
> Just downloaded 3.6.4 and still no fix, very dissappointed

Ditto

Active Daily Users 
3,917,832

Downloads in the last 7 days
248,170

Comment 50

[Ken Saunders]

Sorry, those are Personas Plus stats

Comment 51

[Ryan Doherty (:rdoherty)]

(In reply to comment #48)
> Just downloaded 3.6.4 and still no fix, very dissappointed

The fix is part of Firefox and slated for version 3.6.5

Comment 52

[Ken Saunders]

Looking forward to it.

The fact that this bug is frequently brought up by Personas Plus users is why I mentioned the stats. It affects a major feature (imo).
It's just a bummer, ya' know?

Thanks Ryan

Comment 53

[Scott Finnell]

I don't know why they are waiting for the next release to fix this. This should have been fixed in the last release. I don't know the nuts and bolts of fixing this, and maybe it can't be fixed until something else is fixed in the next release, but for those of us who use this to create persona's, it is quite disappointing.

Comment 54

[Dave Townsend [:mossop] (PTO until Aug 21st)]

(In reply to comment #53)
> I don't know why they are waiting for the next release to fix this. This should
> have been fixed in the last release. I don't know the nuts and bolts of fixing
> this, and maybe it can't be fixed until something else is fixed in the next
> release, but for those of us who use this to create persona's, it is quite
> disappointing.

The patch simply did not land in time for the Firefox 3.6.4 release (which went through an overly long QA and release process due to the amount of changes that were being included in that update).

Comment 55

[BrianZ]

(In reply to comment #51)
> The fix is part of Firefox and slated for version 3.6.5

Well, since version 3.6.6 just came out, does that mean it's fixed now, and has anybody tried it?

Comment 56

[Dave Townsend [:mossop] (PTO until Aug 21st)]

(In reply to comment #55)
> (In reply to comment #51)
> > The fix is part of Firefox and slated for version 3.6.5
> 
> Well, since version 3.6.6 just came out, does that mean it's fixed now, and has
> anybody tried it?

No, unfortunately some issues were found with 3.6.4 that were deemed serious enough to do a quick release of 3.6.6 with just a single fix to correct them (3.6.5 is being skipped for unrelated reasons). The fix that this requires is currently slated to land in the 3.6.7 release, assuming no other version renumbering weirdness goes on.

Comment 57

[Jose E. Bolanos]

Attachment: Proposed patch-Jose

This patch is not tested, but according to:
https://bugzilla.mozilla.org/show_bug.cgi?id=556334
a new method called setLocalTheme was added to the LightweightThemeManager, which would allow the custom persona to be set properly. This patch uses this method to apply custom personas, if it's available.

Comment 58

[MitchellK]

3.6.7 was pushed out today and the apply custom persona bug is still NOT fixed. So I guess we wait until 3.6.8 or 3.6.9 or 5.0  ???? This really can't be rocket science to fix this.

Comment 59

[Dave Townsend [:mossop] (PTO until Aug 21st)]

(In reply to comment #58)
> 3.6.7 was pushed out today and the apply custom persona bug is still NOT fixed.
> So I guess we wait until 3.6.8 or 3.6.9 or 5.0  ???? This really can't be
> rocket science to fix this.

The necessary fix was included in Firefox 3.6.7, all we're waiting for now is for this bug to be fixed and a new version of the Personas Plus extension to be released to take advantage of it.

Comment 60

[MitchellK]

Thanks for the reply Dave, good to know the bug was fixed and that it's only the plugin holding things back. Any ETA on that fix?

Comment 61

[Ryan Doherty (:rdoherty)]

(In reply to comment #60)
> Thanks for the reply Dave, good to know the bug was fixed and that it's only
> the plugin holding things back. Any ETA on that fix?

The next release of Personas Plus is undergoing review and QA. Our initial estimate is releasing it next week. Thanks!

Comment 62

[Jose E. Bolanos]

I've tested the patch I submitted on comment 57 in Firefox 3.6.7 and it works correctly. The Persona Editor is closed and the custom persona is applied.

Comment 63

[MitchellK]

Did not work for me, tried this morning and it's still not applying the theme. Will have to wait for the update to Personas Plus.

Comment 64

[Ryan Doherty (:rdoherty)]

(In reply to comment #62)
> I've tested the patch I submitted on comment 57 in Firefox 3.6.7 and it works
> correctly. The Persona Editor is closed and the custom persona is applied.

Considering how small this change is I think it's ok to commit without a review.

Comment 65

[Dão Gottwald [:dao]]

The patch actually doesn't look quite correct to me. setLocalTheme should only be used if you expect a theme to reference local resources, i.e. not for themes from the web.

Comment 66

[Dão Gottwald [:dao]]

Oh, I missed the "aPersona.custom &&" part. Looks ok then.

Comment 67

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 458006 [details] [diff] [review]
Proposed patch-Jose

Looks good to me, too. r=myk

Comment 68

[Jose E. Bolanos]

Thanks, fixed in rev:
http://hg.mozilla.org/labs/personas/rev/44f126d61cd2

Comment 69

[Gary]

It seems the bug is back with the latest release - 3.6.8

Comment 70

[Scott Finnell]

This bug is not fixed. It has never been fixed in the last 3 revisions, and I and other people are wondering what is going on? Is this fixable? We are all beginning to wonder if it is?

Comment 71

[Dave Townsend [:mossop] (PTO until Aug 21st)]

As I mentioned in comment 59, you need to wait for an updated version of the Personas Plus extension to come out before this will be fixed. Ryan might be able to say when that will be.

Comment 72

[Ryan Doherty (:rdoherty)]

(In reply to comment #71)
> As I mentioned in comment 59, you need to wait for an updated version of the
> Personas Plus extension to come out before this will be fixed. Ryan might be
> able to say when that will be.

Correct, our current timeline is a RC and QA this week. If all goes well it will be out by end of this week.

Comment 73

[Ken Saunders]

It appears that the same exact Personas Plus issue is now appearing in Thunderbird 3.1 (Win Vista).
I'd appreciate it if someone could confirm this.

Also, will the new (upcoming) version of Personas Plus fix this issue in Thunderbird too? Or will that too take a product update.

I'll gladly help out with testing the new version in Firefox and Thunderbird 3.0 and/or 3.1.

Looking forward to Firefox 4 compatibility too.

Comment 74

[Ryan Doherty (:rdoherty)]

(In reply to comment #73)
> It appears that the same exact Personas Plus issue is now appearing in
> Thunderbird 3.1 (Win Vista).
> I'd appreciate it if someone could confirm this.
> 
> Also, will the new (upcoming) version of Personas Plus fix this issue in
> Thunderbird too? Or will that too take a product update.

Confirmed in Thunderbird 3.1.1 OSX.

I'll test the RC of Personas Plus in Thunderbird once it's built to see if it fixes the issue.

Comment 75

[Ken Saunders]

As I've mentioned a number of times before, I'm not the most knowledgeable or versed in coding or terminology, so follow me on this, but won't it take a patch for Thunderbird itself to fix the issue? 

I haven't looked, but I'm guessing that the Thunderbird team used the same or similar lightweight theme coding from Firefox that caused this bug when they included lightweight theme support in Thunderbird 3.1. Perhaps they were just unaware of it and I was slow to upgrading to 3.1(.1) and just noticed this issue myself.

Comment 76

[jdevlin]

Hi, I am using v3.6.8 and this problem is still present. Clicking ok does nothing, defaults after a few seconds, and cannot apply, or keep my custom personna applied. I see it says down the bottom here "Status:  	
RESOLVED FIXED " -But I see no answer to the problem.

What has been the fix??

Comment 77

[Ryan Doherty (:rdoherty)]

(In reply to comment #76)
> Hi, I am using v3.6.8 and this problem is still present. Clicking ok does
> nothing, defaults after a few seconds, and cannot apply, or keep my custom
> personna applied. I see it says down the bottom here "Status:      
> RESOLVED FIXED " -But I see no answer to the problem.
> 
> What has been the fix??

It's been fixed on our codebase. We will have a release candidate early this week for people to test with. After it's QA'd we'll officially release it on AMO. Thanks!

Comment 78

[Jose E. Bolanos]

I've reopened this bug. In Firefox 3.6.8 the custom persona id needs to be a string instead of an integer value. I'll upload a fix in a bit to address this issue.

Comment 79

[Jose E. Bolanos]

Fixed in rev:
http://hg.mozilla.org/labs/personas/rev/d82687b65148

Comment 80

[Ryan Doherty (:rdoherty)]

Looks like some users are having issues in RC3:

http://groups.google.com/group/mozilla-labs-personas/browse_thread/thread/d3f76a16f7e5b5ef

Jose: can you guys take a look and see if it's reproduceable?

Comment 81

[Jose E. Bolanos]

Ryan,

Seems like they are experiencing two separate issues, but both are corrected in the RC3.

1- Custom Persona Dialog

The problem is that, if there is an old value set to the custom persona preference, then the custom persona will not be refreshed (to the new, correct values, i.e. string id) and the dialog will continue to fail.

So, it should work perfectly in new profiles, or when people haven't run into this issue, but not in the case mentioned above. One way we might be ablt to address this is to force-reset the preference if we detect that an integer value is set to the id.

2- forceSkinning preference

One user reports that personas do not seem to be applied over custom themes when this is preference is set. He says the persona is selected correctly, but no changes seem to occur. This is normal though: most custom themes don't work well with personas on top; personas don't look like they have been applied.

Comment 82

[Ryan Doherty (:rdoherty)]

(In reply to comment #81)
> 1- Custom Persona Dialog
> 
> The problem is that, if there is an old value set to the custom persona
> preference, then the custom persona will not be refreshed (to the new, correct
> values, i.e. string id) and the dialog will continue to fail.
> 
> So, it should work perfectly in new profiles, or when people haven't run into
> this issue, but not in the case mentioned above. One way we might be ablt to
> address this is to force-reset the preference if we detect that an integer
> value is set to the id.

Ok, we should add in code to handle this. Many users will have an old custom persona installed, so we need to handle it.


> 2- forceSkinning preference
> 
> One user reports that personas do not seem to be applied over custom themes
> when this is preference is set. He says the persona is selected correctly, but
> no changes seem to occur. This is normal though: most custom themes don't work
> well with personas on top; personas don't look like they have been applied.

Yep, you are correct. Leave as is.

Thanks!

Comment 83

[Jose E. Bolanos]

We've applied the change discussed in comments #81 and #82 in rev:
http://hg.mozilla.org/labs/personas/rev/04d5cac56954

We'll go ahead an generate a new rc (rc4). I'll mark this as fixed.