554245 - Enabling the default theme after a personas was selected the install status image is broken

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Tony Chung [:tchung]]

Attachment: default theme screenshot

Enabling Default Theme displays an odd status bar image.   See screenshot

Repro:
1) Download Addons project branch nightly: Mozilla/5.0 (Macintosh; U; Intel Mac
OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100321 Minefield/3.7a4pre
2) install a personas themes from getpersonas.com
3) Now reenable the Default theme
4) Verify strange images appear in appearance.

Expected:
- default theme gets renabled, with the right images

Actual:
- odd status bar icons in the default theme and the last selected persona

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

With status bar image you mean the buttons, e.g. "Remove" and "Enable"?

Comment 2

[Tony Chung [:tchung]]

yeah i guess its a merged remove and enable buttons.   THe screenshot makes it clear.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I've been referring to this as the install status.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

It's something we can test as part of another Litmus test.

Comment 5

[Tony Chung [:tchung]]

yeah its the install status, not the enable/disable buttons.   See spec screenshot: https://wiki.mozilla.org/File:Just_searching_onescreen.png

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Pretty sure this will be fixed by bug 561078.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

(In reply to comment #7)
> Pretty sure this will be fixed by bug 561078.

Yes, looks good now. Marking as fixed on the branch.

Comment 9

[Dave Townsend [:mossop]]

Landed on trunk as a part of bug 554007

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100511 Minefield/3.7a5pre ID:20100511030640

Comment 11

[Dave Townsend [:mossop]]

This sort of thing is difficult to test automatically but we should have a manual test for switching themes that should cover this.

Comment 12

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Dave Townsend (:Mossop) from comment #11)
> This sort of thing is difficult to test automatically but we should have a
> manual test for switching themes that should cover this.

Dave, do you think we should also have a litmus manual test for this one?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

That's what he was saying in comment 11.

Comment 14

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Henrik Skupin (:whimboo) from comment #13)
> That's what he was saying in comment 11.

Thanks for clarifications Henrik