Closed Bug 561078 Opened 14 years ago Closed 14 years ago

provider.addonChanged() for themes, naively marks theme as needing restart

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9.3a5

People

(Reporter: Unfocused, Assigned: mossop)

References

Details

(Whiteboard: [rewrite])

Attachments

(1 file)

When a lightweight theme is active, and the default theme is enabled by the user, the default theme is marked as pending enable, while the lightweight theme isn't disabled until after restart. This seems to be because addonChanged() always marks the theme as pending enable, regardless of whether it needs a restart or not.
Blocks: 554245
Priority: -- → P1
Blair, I think http://hg.mozilla.org/projects/addonsmgr/rev/15c277ba6fbe has fixed this, can you confirm that please.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
(In reply to comment #1)
> Blair, I think http://hg.mozilla.org/projects/addonsmgr/rev/15c277ba6fbe has
> fixed this, can you confirm that please.

Confirmed - works great now.
Which parts could not be covered by an automated test?
Flags: in-testsuite?
Flags: in-litmus?
Attached patch patch rev 1Splinter Review
Just need to pass needsRestart correctly. Includes a test to verify this behaviour.
Attachment #441835 - Flags: review?(robert.bugzilla)
(In reply to comment #3)
> Which parts could not be covered by an automated test?

Added an automated test for this from the API point of view, don't know if Blair's handling needs manual testing though.
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus?
Flags: in-litmus-
Attachment #441835 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
(In reply to comment #5)
> Added an automated test for this from the API point of view, don't know if
> Blair's handling needs manual testing though.

Nothing specific to this bug, no.
http://hg.mozilla.org/mozilla-central/rev/4d99bc08df86
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Verified fixed with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: