Closed
Bug 561078
Opened 15 years ago
Closed 15 years ago
provider.addonChanged() for themes, naively marks theme as needing restart
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: Unfocused, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
|
2.44 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
When a lightweight theme is active, and the default theme is enabled by the user, the default theme is marked as pending enable, while the lightweight theme isn't disabled until after restart. This seems to be because addonChanged() always marks the theme as pending enable, regardless of whether it needs a restart or not.
|
Reporter | |
Updated•15 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 1•15 years ago
|
||
Blair, I think http://hg.mozilla.org/projects/addonsmgr/rev/15c277ba6fbe has fixed this, can you confirm that please.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
|
|
Reporter | |
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Blair, I think http://hg.mozilla.org/projects/addonsmgr/rev/15c277ba6fbe has
> fixed this, can you confirm that please.
Confirmed - works great now.
|
||
Comment 3•15 years ago
|
||
Which parts could not be covered by an automated test?
Flags: in-testsuite?
Flags: in-litmus?
|
|
Assignee | |
Comment 4•15 years ago
|
||
Just need to pass needsRestart correctly. Includes a test to verify this behaviour.
Attachment #441835 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Comment 5•15 years ago
|
||
(In reply to comment #3)
> Which parts could not be covered by an automated test?
Added an automated test for this from the API point of view, don't know if Blair's handling needs manual testing though.
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus?
Flags: in-litmus-
|
||
Updated•15 years ago
|
Attachment #441835 -
Flags: review?(robert.bugzilla) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
|
|
Reporter | |
Comment 6•15 years ago
|
||
(In reply to comment #5)
> Added an automated test for this from the API point of view, don't know if
> Blair's handling needs manual testing though.
Nothing specific to this bug, no.
|
|
Assignee | |
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Comment 8•15 years ago
|
||
Verified fixed with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•