554265 - Search engine icons are not downloaded if searchplugin is readonly

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

As per the comment in _setIcon:
// No use downloading the icon if the engine file is read-only

My guess is this comment predates the search.json cache, and nowadays, downloading the icon works even if you can't overwrite the searchplugin file.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Same patch, in a (more readable) diff -w form

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Benjamin really isn't the right reviewer for that. Looks good to me, but I'll defer r+ to Ryan (rflint@mozilla).

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 434191 [details] [diff] [review]
Patch

>diff --git a/toolkit/components/search/nsSearchService.js b/toolkit/components/search/nsSearchService.js
>@@ -1453,47 +1453,44 @@ Engine.prototype = {
>-        // No use downloading the icon if the engine file is read-only
>-        if (!this._readOnly) {

The cache can be disabled, so leave a conditional here and make it return early if (this._readOnly && !getBoolPref(BROWSER_SEARCH_PREF + "cache.enabled", true)).

Thanks for the patch!

Comment 5

[Mike Hommey [:glandium]]

Attachment: Patch v2

How about this ?

Comment 6

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/8dd00e5122fb