55444 - [mac] profile migration fails on not finding certain 4.x files and folders

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P3)

Description

[racham]

I noticed that profile migration failing when the user's 4.x profile does not 
have one of the following folders.

* Mail folder 
* News folder
* ImapMail folder (if the user has an imap account)

Additionally on Macintosh : MagicCookie file

I ran into various situations which exposed this bug.

1. I create a 4.x profile and created an imap account. I didn't login into my 
imap account in 4.x. So, ImapMail folder is never created on 4.x. Now, when I 
tried to migrate the profile, I profile won't migrate as it won't find ImapMail 
folder. This might not be a common case. But it still probably is not the right 
thing to do.

2. I got very close to wrapping up with bug 44764 (japanese profiel migration) as 
I could get one of the japanese profiles migrated successfully on mac. Here is 
the case, If I create a profile using english communicator on Japanese OS, 
messenger creates Mail, News folders (and ImapMail folder on login for iamp 
accounts). So, I created one profile like that and logged into imap account. Now 
when I migrated the profile, it got migrated without any problems. Later I 
created a profile using japanese communicator build. In that profile, messenger 
created 'Mail' and 'News' folder names in japanese characters (a note here 
ImapMail folder name is created in english only). Now, when I tried to migrate 
this profile the profile migration code looks for folder names "Mail" and "News" 
(folder names in english) [http://lxr.mozilla.org/seamonkey/source/profile/pref-
migrator/src/nsPrefMigration.cpp#156] and it didn't find them and migration 
failed. 

3. Also, another case [Mac only] was exposed when I tried to migrate after making 
sue that I have Mial, News and ImapMail folders. My 4.x profile didn't have a 
MagicCookie as it was a new profile and I didn't go a site that sets any cookies. 
So, profile migration failing to open the MagicCookie file bailed out and the 
migration was unsuccessful. I guess we need to check for the existence of the 
file before we try to poen and fail. Also, I think if we fail to open the cookie 
file for some reason, we should let user know of the fact and finish the 
migration of the profile. 

Seth should be able to tell us about the importance of the existence of those 
mail folders as factors to profile migration success/failure. Assigning this bug 
to him. 

This bug is generic profile migation problem.

Comment 1

[racham]

nominating for rtm.

Comment 2

[racham]

Adding Scott Putterman to the cc list.

Comment 3

[scottputterman]

marking rtm need info.

Comment 4

[(not reading, please use [e-mail] instead)]

I believe sairuh has hit case #1 before, adding her to the cc list.

fixing #1 and #3 will be easy.  I'll start on a fix for them now.

fixing #2 is covered in bug #55449

accepting.

Comment 5

[(not reading, please use [e-mail] instead)]

I believe sairuh has hit case #1 before, adding her to the cc list.

fixing #1 and #3 will be easy.  I'll start on a fix for them now.

fixing #2 is covered in bug #55449

accepting.

Comment 6

[(not reading, please use [e-mail] instead)]

the MagicCookie mac bug is now bug #55955

Comment 7

[(not reading, please use [e-mail] instead)]

what platform did you observe #1?

on win32, I created a profile that used imap in 4.x, then quit
I was able to migrate fine.  (my imap account, my bookmarks and my prefs came
over fine.)

Comment 8

[dbragg]

Same results for me on WinNT (i.e. successful eventhough there were no mail
directories).  The only way I was able to make it error out was to remove the
prefs.js file.

Comment 9

[(not reading, please use [e-mail] instead)]

hmm, maybe I was testing this wrong.

I'm going to try again, but by removing my "Mail" and "News" directories from my
4.x profile and see what happens.

if that does cause the problem, (which would match the scenario a japanese user
would hit in bug #55449) then this should be easy to fix.

Comment 10

[(not reading, please use [e-mail] instead)]

hmm, removing "Mail" and "News" didn't seem to cause migration to fail.

Comment 11

[(not reading, please use [e-mail] instead)]

zoinks!  winnt handles this, but not my mac.

you meddling kids.

Comment 12

[dbragg]

Figures.  I think Old man Witherspoon works for Apple.

Comment 13

[(not reading, please use [e-mail] instead)]

ok, I see the problem.  the reason it doesn't fail on winnt is differences in
the file spec implementations.

fix in hand.

Comment 14

[(not reading, please use [e-mail] instead)]

here's the fix:

***************
*** 2049,2052 ****
--- 2052,2061 ----
    rv = NS_FileSpecToIFile(&pathSpec, getter_AddRefs(pathFile));
    if (NS_FAILED(rv)) return rv;
+
+   PRBool exists = PR_FALSE;
+   pathFile->Exists(&exists);
+
+   NS_ASSERTION(exists, "the path does not exist.  see bug #55444");
+   if (!exists) return NS_OK;

  	rv = m_prefs->SetFileXPref((const char *)premigration_pref, pathFile);

Comment 15

[(not reading, please use [e-mail] instead)]

r=putterman, sr=mscott

the problem was we'd fail to migrate because we'd fail to set the "premigration"
pref.

now, if the path points to a folder that doesn't exist, we just gracefully fail.

Comment 16

[scottputterman]

marking [rtm++]. I was just in a meeting where PDT agreed to mark this rtm++ and
it looks like we moved onto a different bug before hitting submit.

Comment 17

[(not reading, please use [e-mail] instead)]

fixed.

remember, you need to be on a mac to verify this.

Comment 18

[Grace Bush]

reproduced the bug on an old build-verified fix on build 20001018008MN6

Comment 19

[John Unruh]

Verified on the 10/31 Mac trunk build.