Closed Bug 55449 Opened 24 years ago Closed 16 years ago

Recognize 4.x locallized "Mail" and "News" folder names and copy content to 6.0

Categories

(MailNews Core :: Profile Migration, defect)

Product:
MailNews Core
Component:
Profile Migration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: racham, Unassigned)

References

Details

(Keywords: intl, Whiteboard: [rtm++])

Attachments

(5 files)

a patch-in-progress off the tip
12.92 KB, patch
Details | Diff | Splinter Review
the latest version of the fix
13.41 KB, patch
Details | Diff | Splinter Review
final version of the patch, should work for both 4.5 JA and 4.7 JA
12.60 KB, patch
Details | Diff | Splinter Review
Screen shot of profile files created by French 4.5
21.82 KB, image/jpeg
Details
Screen shot of profile files created by German 4.5
23.36 KB, image/jpeg
Details 
While fixing the bug 44764, I came across this bug on macintosh japanese machine.
Today, profile migration code while setting premigration prefs looks for folders 
"Mail" and "News" folders (http://lxr.mozilla.org/seamonkey/source/profile/pref-
migrator/src/nsPrefMigration.cpp#156). I mean we look for english strings "Mail" 
and "News" in 4.x folder. Unforunately, that very mechanism fails migration 
process on japanese macintosh. 

If I am a japanese mac user and I create a brand new profile with japanese ma 4.x 
communicator. This profile, besides all other default profile files, also comes 
with Mail and News folders already created. These folder names are in japanese. 
So, when we do migration to 6.0, the migration code looks for "Mail" a folder 
name in english and it will not find it and fails to migrate (bug 55444). Same is 
the story with "News" folder. 

So, either we try to access these folders properly by introducing localized 
string mechanism. That means the we get the name of folders from properties file. 
That will get us around the migration problem. I think we may also need to extend 
this mechanism to sompe parts of mailnews code also as it might also be simply 
looking for "Mail" and "News" folders.

Side Notes : 

* ImapMail folder when logged in creates english folder named "ImapMail". So, 
this is not a problem.
 
* On windows, "Mail", "News" and "ImapMail" folder names are all created in 
english on japanese mac with a japanese communicator. So, no problems are noticed 
on this platform.

Japanese mac profile migration (people using japanese mac machines and using 
japanese communicator builds) depends this one. Will add the dependency in bug 
44764.
Blocks: 44764
changing QA contact to teruko and adding Grace to the cc list.
QA Contact: gbush → teruko
Hi, Naoki:


Any comment on the proposed solution?


thx

So the problem was in localized 4.x Macintosh, "Mail" and "News" folder were
localized. I think that was a mistake it should not have been localized.

In order to support the localized folder names for migration, we may put the
names in a property file and rename to "Mail" or "News" in 6.0. But that causes
a problem for the users who have been using non-localized 4.x and try to migrate
to localized 6.0.

I do not know how many localized language do we have for 4.x. Also not sure if
we localized the folder names only for Japanese 4.x or other localized Macintosh
4.x too.
If those numbers are limited then we may actually hard code those localized
strings and try to match until they are found. This way we can migrate from any
localized Macintosh 4.x.






> So the problem was in localized 4.x Macintosh, "Mail" and "News" folder were
> localized. I think that was a mistake it should not have been localized.

agree

>In order to support the localized folder names for migration, we may put the
>names in a property file and rename to "Mail" or "News" in 6.0.
yes
>But that causes
> a problem for the users who have been using non-localized 4.x and try to
> migrate to localized 6.0.


> I do not know how many localized language do we have for 4.x. Also not sure if
> we localized the folder names only for Japanese 4.x or other localized
> Macintosh 4.x too.
> If those numbers are limited

I think this can be find out by searching our CD archive. Is this a 4.x -> 6.0
specific problem or pre-4.0 releases might also have this problem?

> then we may actually hard code those localized
> strings and try to match until they are found. This way we can migrate
> from any localized Macintosh 4.x.

Can we look at 4.x code to find out? How did localize 4.x name these folder?

nominating for rtm.
Keywords: rtm
Adding Scott Putterman to the cc list.
Keywords: rtm
really nominating for rtm and marking rtm need info.

When we migrate is there any way to tell where the "Mail" and "News" folders are
located and then chop of the localized names and put "Mail" and "News" in their
place?  We should definitely copy these over to the non localized directories as
well.

Or could we add some code to migration that would first look for "Mail" and
"News" and if it didn't find them would look for the localized directories and
then copy them to the non localized directories in 6.0?  This would mean we'd
have to add two more localized strings but it would be worth it.
Keywords: rtm
Whiteboard: [rtm need info]
Changed the summary because we don't want to have localized name for 6.0 but
just want to recognized localized name of 4.x.
Summary: We need locallized names for "Mail" and "News" folders → Recognize 4.x locallized "Mail" and "News" folder names and copy content to 6.0
we use the default locations if they were not set in the prefs.

so, if the "mail.directory" pref was not set in 4.x, the code assumes it was in
a folder named "Mail" in the 4.x profile directory.

putterman's suggestion makes sense to me:

1) first check the mail.directory pref
2) second, look for a directory in the 4.x profile directory named "Mail"
3) third, look for a directory in the 4.x profile directory with the localized
string for "Mail".

right now, we already do steps 1 and 2.  adding step 3 would not be difficult,
we'd just have to make sure we localized the string "Mail" the same way we did
in 4.x

the migration code copies the folders over, and will rename them properly for 6.0

accepting.  I'm off to work on the fix.
Status: NEW → ASSIGNED
The last localized 4.x mac Japanese version is 4.7.  I will test this in 4.7JA mac build.
Put jaimejr@netscape.com and msanz@netscape.com in cc list.


Who could we add from the 4.x team that could tell us about the localizations
done for other languages?

changing platform to all.
Hardware: Macintosh → All
this is not going to be as easy as I thought.

the pref migration code that needs fixing uses nsIFileSpecs

to implement this fix, I need to use nsILocalFiles which have the appropriate
wstring interfaces.  the fix I was planning was:

get the string bundle that contained the localized version of "Mail" for the
platform
if "<4.x profile dir>/Mail" did not exist, check for "<4.x profile
dir>/<localized string for 'Mail'>", and if it exists, use it.


the fix for this bug would be "bigger than a bread box" and need significant
testing.

I'll discuss this with racham and selmer.  my guess is that it will be rtm- for
6.0, but this would be something we'd like to fix for the next version.

the basic plan would be:

rewrite nsPrefMigration.cpp to only use nsILocalFile
then, implementing this fix would be simple.

PDT opinion is to attempt the fix.  If small and safe and works on trunk before
Friday, then will consider for rtm.

I've got a patch worked up.  now I've got to test and debug it.

I'll attach the patch here, just so pdt knows I'm working on it.
Whiteboard: [rtm need info] → [rtm need info] testing a potential fix
updating summary
Whiteboard: [rtm need info] testing a potential fix → [rtm need info] checked fix into trunk
I've checked a fix into the tip.

tomorrow, I plan to work with nhotta, tao, or teruko to verify that the fix will
work when migrating from an over-localized 4.x JA client.

Here are unicode strings for Japanese "Mail" and "News".

For mail, \u30E1\u30FC\u30EB
For news, \u30CB\u30E5\u30FC\u30B9

Seth, how bad would it be if this weren't in the rtm?  pdt is tightening and a
strong justification will be needed for this.  Are the conditions leading to
this bug widespread among users?

I think a comment from I18N would be interesting as well to know how widespread
Japanese mac usage is. But, if you look up a few comments, you'll see that it
was PDT who asked us to look into this when I went to them looking for an rtm-.

Jaime, can you comment on Mac JA usage?
Daniel, what have you done in French and German, are these words localized?

"15% of the OS marketplace is Macintosh" (source:
http://client/international/html/japan.htm)

Based off my past experience while at Canon, I can say Apple is very strong in
Japan.

good news.  nhotta and I got a trunk build, localized migration.properties and
migration worked as expected.

r=putterman

I'm off to seek a super review.
sr=mscott

for risk consideration:  if the english version of the folder exists ("Mail" and
"News") we always use that, just like before.  The only difference in behaviour is:

if "Mail" doesn't exist, and <Localized word for Mail> does, we use the latter.

seeking pdt approval.
Whiteboard: [rtm need info] checked fix into trunk → [rtm+] checked fix into trunk
rtm++ since it works on the trunk. You guys better test the heck out of this 
with JA and non-JA migrations, on all platforms. The size of the patch would 
probably get an rtm- except for the severity of the bug.
Whiteboard: [rtm+] checked fix into trunk → [rtm++] checked fix into trunk
I tested his fix on Naoki's Mac system from 4.5JA Mac build.  It works fine.  
Also, I tested Windows trunk build, Profile migration works fine for Japanese
 profile name.  

However, I found the following problems in 4.x Japanese version.
4.5 creates "Mail" and "News" folder names in Japanese.
4.7 creates "Mail" and "News" folder names in Japanese, and it creates "Mail" in English
folder as well.  English "Mail" folder contains 2 welcome mails.  Japanese "Mail" folder
contains users mails.  

Without his fix, I tried the following.
I created Japanese Profile in 4.7 which including some mails in inbox.  
I could migrate the Profile in Netscape 6 (2000-10-13-08MN6 build), but inbox contains
only these 2 welcome files.  News does not migrated at all.

With his fix, I could migrate Japanese profile from 4.5 JA mac build, but I could not
migrate Japanese profile from 4.7JA mac build.

Jaime or Montse, what do you think?
hmmmmm . . . we may have run out of time on this one. We should continue to work 
on it, just in case we can check it in next week (PDT allaowed).
Reading Seth's comment about the patch:
>for risk consideration:  if the english version of the folder exists ("Mail" and
>"News") we always use that, just like before.  The only difference in behaviour is:
>
> if "Mail" doesn't exist, and <Localized word for Mail> does, we use the latter.



It seems that the problem results from the difference between 4.5 & 4.7's
implementation. With a little bit more punding, we might be able to fix both
cases.

Since the user data are in Japanese's folders, we might want to test if
localzied folder names exist first. Any thought?

I think it's worthwhile to get the fix in. Better to have 4.7 migration not work
than to have 4.7 and 4.5 migration not work. If we can get PDT to allow us to
work on it longer then maybe we can persist on a new bug for 4.7, but unless I'm
missing something, with this patch 4.7 is no worse than before and 4.5 now works.
hmm.  the fact that users can have both Mail and <Localized word for Mail> is
problematic.  

(strange that this is new to 4.7.)

what a mess.

the current order is 
	pref, Mail, <Localized word for Mail>
switching to 
	pref, <Localized word for Mail>, Mail 

would fix the 4.7JA, but we may find a scenario where switching would cause
problems.

some possibilites possiblities:

1)  don't check in.  it's close to the wire.  play it save, don't check it in.
sorry NS 4.x JA mac users.
 
2)  check it in, and break 4.7 JA migration

3)  be even clever about determining the old path.  (in 4.x, there might be
prefs that point to the Sent, Drafts, Templates, Unsent Messages folder.   for
pop users, these have to point to the old path.)  in theory, this would give us
better answer to:  where does your 4.x local mail live?
I agree with putterman:  having 4.5 work is better than having neither.

since I've got the rtm+, I'm going to check it in, and see what would be
involved in getting 4.7 and 4.5 JA to work.
looking at a 4.7 mac 'Netscape Preferences' file, we are not guaranteed to have
have any of those prefs set.

so that hack won't work.
teruko / tao:  it seems strange to me that 4.7 has a "Mail" directory with those
two messages, but 4.5 doesn't.

are those two messages 4.7 specific?  I've seen those two messages on new pop
accounts, before 4.7.  (one is a welcome from Marc Andreesen, right?)
I realized the 2 mails in English Mail folder in 4.7 JA Mac build is not show in the Messenger.
I looked at the Inbox in English Mail as file.  After I migrate this profile to Netscape 6, I see 2 mails are there.
The English Mail folder does not do anything in 4.7JA Mac.
slightly new patch.  new patch has been reviewed.  r=putterman, sr=mscott.

pdt:  the new change to the patch is to change the order.  the new order is:

check the pref, if set use it.
if not set, use <4.x profile directory>/<Localized word for "Mail"> if it exists
if it doesn't exist, use <4.x profile directory>/"Mail"

since the patch changed, going back to rtm+
Whiteboard: [rtm++] checked fix into trunk → [rtm+] checked fix into trunk
Thanks a lot, Seth. It's great to have fixed both!

rtm++ after discussing latest change with sspitzer -- it's a small change over
what teruko already tested successfully on the trunk.
Whiteboard: [rtm+] checked fix into trunk → [rtm++] checked fix into trunk
fixed on trunk and branch.  thanks to all involved.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: [rtm++] checked fix into trunk → [rtm++]
Verified fixed in 2000-10-14-08 MN6 Mac build.  Also, tested 2000-10-15-09 MN6 Win32 build.  
Migration works fine.
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Has anybody tried other Macintosh localized 4.x (French, German)?
If "Mail" and "New" are also localized then L10N should localize the
migration.property otherwise those should stay as English.

French 4.5 Macintosh
Mail - Courrier
News - Nouvelles

German 4.5 Macintosh
Mail - Mail
News - Diskussionen

I could not find 4.7 Macintosh for French and German.

very interesting.

we originally thought over localization was 4.7 only, but we had a hunch it was
4.5 too.

this makes the fix we checked in even more valuable.

we've got to make sure we properly localize "Mail" and "News" the same we did in 4.5
>we've got to make sure we properly localize "Mail" and "News" the same we did
in 4.5

You mean in migration.properties, right? We do not want to localize the actual
folder names, they should stay as English.

yes, to clarify:  we must localize "News" and "Mail" in migration.properties the
same way we did in 4.x
Montse, I could not find German or French Mac 4.7 in public sites.  
Do you know whether which version Dublin localized 4.6, 4.5, or 4.7 Mac build?
Daniel, can you confirm which are the latest FR and DE Mca versions? Maybe we
didn't ship them after 4.5?
I think it's time for the L10N part of this bug to split off into its own bug.
I've filed bug 57058 for that purpose.  Please move this discussion to that bug
and preserve this bug for any problems with Seth's code fix.  Thanks.
I tested French 4.5 to migrate the profile.  Works fine.
Reopening to Resolve as Fixed.  Bugs stay resolved until verified on both the
branch and the trunk.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Resolving as Fixed.  vtrunk keyword is in place requesting trunk verification
before this bug changes state to Verified.  When this is verified on the trunk
vtrunk keyword should be removed and the bug Status should be set to Verified.
Sorry for the spam, just trying to make sure we cover all of our bases here.
To ji for verification. This is Mailnews migration.
Product: Browser → MailNews
QA Contact: teruko → ji
Adding jenm to cc: list.
I'll verify this when a Japanese 6.5 is available.
Verified with 07/05 Mac Japanese build. It's fixed. Migration from 4.5 Ja and 
4.7 Ja to NS 6.1 ja is working.
Status: RESOLVED → VERIFIED
Marina has found it's not working when migrating from 4.7 En to 6.2 Ja.
It looks inot the wrong dir and will pull all the english files from there
including cache, bookmarks, securities etc that will all display under the mail
account tree. 
Seth, from your comments at 2000-10-13 16:04 and 2000-10-13 17:36 the order
should be 
pref, <Localized word for Mail>, Mail 

But it seems not working in this case (from 4.7 En to 6.2 Ja)
Reopened.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Keywords: nsrtm, vtrunk → intl, nsbeta1
Xianglan and Marina, does the migration from 4.7JA to 6.2JA work?
Yes, it's working when migrating from 4.x Ja to NS 6.2 Ja.
it is working as long as you migrate the same language version, say Fr to Fr and
Ja to Ja etc., if one of the languages is different then you'll see all those
difs files as mail folders under your mail account...
Keywords: nsbeta1 → nsbeta1-
Setting OS->ALL. If this appears on all hardware, it can't be a mac classic only
bug.
OS: Mac System 8.5 → All
Product: MailNews → Core
Do we care as much about localized 4.x profiles anymore? Is this bug still a
concern to anyone or can it be WONTFIXed?

Waiting a month for feedback, then WONTFIXing.
sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.
Assignee: sspitzer → nobody
Status: REOPENED → NEW
Filter on "Nobody_NScomTLD_20080620"
QA Contact: ji → profile-migration
Product: Core → MailNews Core
Priority: P3 → --
(In reply to comment #65)
> Do we care as much about localized 4.x profiles anymore? Is this bug still a
> concern to anyone or can it be WONTFIXed?
> 
> Waiting a month for feedback, then WONTFIXing.

We've now waited 3.5 years without feedback, 4.x is long ago dead, 4.x migration code has been ripped out afaik, resolving WONTFIX.
Status: NEW → RESOLVED
Closed: 24 years ago → 16 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: