Closed Bug 554448 Opened 15 years ago Closed 15 years ago

XPC_COW_FunctionWrapper does not wrap arguments

Categories

(Core :: XPConnect, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- unaffected
status1.9.1 --- unaffected

People

(Reporter: moz_bug_r_a4, Assigned: mrbkap)

References

Details

(Keywords: regression, Whiteboard: [sg:critical])

Attachments

(1 file)

This is a regression from bug 533600 and bug 542428. When content calls a method of FeedWriter, funToCall is a content function and thus scope is a content window. Thus, if an argument is a JS object, XPCWrappedNativeScope::GetWrapperFor returns UNKNOWN.
Attached patch Proposed fixSplinter Review
I just spent a while talking to Clint about trying to test GetWrapperFor. I think we have a plan, but it's going to take some time to implement. Here's a fix in the meantime.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #434417 - Flags: review?(jst)
Attachment #434417 - Flags: review?(jst) → review+
Blocks: 533600, 542428
Keywords: regression
Whiteboard: [sg:critical]
Attachment #434417 - Flags: superreview?(jonas)
Attachment #434417 - Flags: superreview?(jonas) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Group: core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: