554576 - Force SCRIPT_NAME='' for darklaunch pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
Go to https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/le

observed behavior:
URLs in search results include /z

example: 
<link>
https://addons.mozilla.org/z/en-US/firefox/user/5119145/?src=api
</link>

Comment 1

[Jeff Balogh (:jbalogh)]

oremj: we should be forcing the SCRIPT_NAME to '' if X-amo-darklaunch is in the headers.  Can we do that in Apache?  If not, we can handle it in zamboni.wsgi.

Comment 2

[Jeremy Orem [:oremj]]

When I rewrite from /z -> / it fixed the script_name, but for darklaunch stuff I think you'll need to use the X-amo-darklaunch header.

Comment 3

[Jeff Balogh (:jbalogh)]

How can I tell from the request/environment that this is a darkluanch page?

Comment 4

[Jeremy Orem [:oremj]]

I've been doing          http.addHeader( "X-Zeus-DL-PT", "552612" );

so you can just check if X-Zeus-DL-PT is there.

Comment 5

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/40a7302

Comment 6

[krupa raj[:krupa]]

I still see /z in some of the URLS listed in 

    https://preview.addons.mozilla.org/en-US/firefox/api/1.5/search/le

    <link>
    https://preview.addons.mozilla.org/z/en-US/firefox/user/1503622/?src=api
    </link>

reopening

Comment 7

[krupa raj[:krupa]]

Attachment: screenshot

Comment 8

[Jeff Balogh (:jbalogh)]

Attachment: preview.amo/admin/env output

Comment 9

[Jeff Balogh (:jbalogh)]

This is where I tried to fix the SCRIPT_NAME for dark launch pages: http://github.com/jbalogh/zamboni/commit/40a730200b.

It works locally when I have `RequestHeader set X-Zeus-DL-PT 55` in my httpd.conf.  I can see the right header in the admin/env output in attachment 435651 [details].  Is it possible that zamboni.wsgi isn't getting loaded properly?

oremj, clouserw, any ideas?

Comment 10

[Jeremy Orem [:oremj]]

Should I just uncomment:

# def application(env, start_response):
#     start_response('200 OK', [('Content-Type', 'text/plain')])
#     return '\n'.join('%s: %s' % item for item in sorted(env.items()))

Comment 11

[Jeff Balogh (:jbalogh)]

oremj figured out that we need to set SCRIPT_URL: http://github.com/jbalogh/zamboni/commit/b3cbdc01

You shouldn't see /z in dark launch urls anymore.

Comment 12

[krupa raj[:krupa]]

verified that "X-amo-darklaunch: z" pages do not have the /z in URLs

https://preview.addons.mozilla.org/en-US/firefox/api/1.5/search/le  does not have any URLs with /z