Closed Bug 554583 Opened 13 years ago Closed 13 years ago

Failed to configure firefox on Solaris

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Solaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a4

People

(Reporter: eagle.lu, Assigned: eagle.lu)

References

Details

Attachments

(1 file)

use '=' instead of '-eq'
593 bytes, patch
ted
: review+
Details | Diff | Splinter Review 
Failed to run configure on Solaris
Assignee: nobody → brian.lu

        Attachment #434484 -
        Flags: review?

    
  
Assignee: brian.lu → nobody
Product: Firefox → Core
QA Contact: build.config → build-config

    
  

        Attachment #434484 -
        Flags: review? → review?(ted.mielczarek)

    
    

    
  
For sh on Solaris, -eq can only be used for comparing numbers. comparing strings should use "=".

We can also use "-z" here.
Status: NEW → ASSIGNED

        Attachment #434484 -
        Flags: review?(ted.mielczarek) → review+
Assignee: nobody → brian.lu

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/d138ed38ee2d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Blocks: 552385
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a4

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.