554951 - Context menu behavior and style fixes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The new context menu needs some fixes:
* Menu items do not highlight when tapped
* The menu itself does not resize to hold the number of menu items. If two items are displayed in an instance, then the menu tries to show one itme in the next instance, the menu container is still sized to hold two items.
* Save Image will save, even if the file picker is canceled

Comment 1

[Aakash Desai [:aakashd]]

For the second bullet point, a testcase would be the following:

1. Go to www.slickdeals.net
2. long click on a rss image button and view the context menu
3. long click on the "Hot Topics" hyperlink


As you get testcases for other bullet points, please add them to this bug. I'd like to regression test them on litmus in the future.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Patch fixes:
* Highlight on tap
* Filter out unsafe link protocols
* Resizing panel

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 434929 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
>+/* Force any command tap to highlight */
>+#context-commands > richlistitem:active {
>+  background: #8db8d8;
> }

use #context-commands > richlistitem:hover:active {

>+/* Force any command tap to highlight */
>+#context-commands > richlistitem:active {
>+  background: #8db8d8;
>+}
>+

idem

r+ with the css address

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with comments addressed:
http://hg.mozilla.org/mobile-browser/rev/67649d1c89de

Comment 5

[Jan D]

UI suggestion: The notifications appeare close to the tab-panel and at the y-position of the newly opened tab. I had some trouble getting this. I think it could be made clearer by getting rid of the space between notification and left screen edge. A mockup of this is here: http://www.flickr.com/photos/31068346@N05/4465901942/

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED for the three use cases listed in comment #0 on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100329 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100329 Namoroka/3.7a4pre Fennec/1.1a2pre

Comment 7

[Aakash Desai [:aakashd]]

litmus testcases:

https://litmus.mozilla.org/show_test.cgi?id=11656
https://litmus.mozilla.org/show_test.cgi?id=11654

regression test this bug.