Last Comment Bug 555508 - The 'active' attribute is gone, should instead use -moz-window-inactive pseudoclass
: The 'active' attribute is gone, should instead use -moz-window-inactive pseud...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1a2
Assigned To: Stefan [:stefanh]
:
:
Mentors:
Depends on: 508482
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-27 18:59 PDT by Stefan [:stefanh]
Modified: 2010-05-20 11:54 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix style rules (4.63 KB, patch)
2010-03-27 18:59 PDT, Stefan [:stefanh]
neil: superreview+
Details | Diff | Splinter Review
New version with pageInfo and DM as well (7.08 KB, patch)
2010-03-31 10:11 PDT, Stefan [:stefanh]
no flags Details | Diff | Splinter Review
Updated for bitrot (7.11 KB, patch)
2010-04-01 06:22 PDT, Stefan [:stefanh]
mnyromyr: review+
neil: superreview+
Details | Diff | Splinter Review

Description Stefan [:stefanh] 2010-03-27 18:59:44 PDT
Created attachment 435435 [details] [diff] [review]
fix style rules

The -moz-window-inactive pseudoclass introduced in bug 508482 made some styles rules in mac classic obsolete (they doesn't work anymore since the xul attribute was removed). We should use the new pseudoclass instead.
Comment 1 Stefan [:stefanh] 2010-03-27 19:10:20 PDT
-#messengerWindow:not([active="true"]) > #mailContent > #messengerBox > #folderPaneBox {
+#folderPaneBox:-moz-window-inactive {
   background-color: #E8E8E8;
 }


As a curiosity, the old rule doesn't work on 2.0.x. Maybe caused by tabmail?
Comment 2 Stefan [:stefanh] 2010-03-28 13:12:32 PDT
(In reply to comment #1)
> As a curiosity, the old rule doesn't work on 2.0.x. Maybe caused by tabmail?

Yep, caused by tabmail. Filed bug 555582 for a branch-fix.
Comment 3 Stefan [:stefanh] 2010-03-31 10:11:26 PDT
Created attachment 436216 [details] [diff] [review]
New version with pageInfo and DM as well

Turns out that I forgot pageInfo and DM :-/
Comment 4 Stefan [:stefanh] 2010-04-01 06:22:00 PDT
Created attachment 436457 [details] [diff] [review]
Updated for bitrot
Comment 5 Stefan [:stefanh] 2010-04-01 06:22:45 PDT
Comment on attachment 436457 [details] [diff] [review]
Updated for bitrot

I bitrotted myself in bug 556102...
Comment 6 neil@parkwaycc.co.uk 2010-05-19 15:50:46 PDT
Comment on attachment 436457 [details] [diff] [review]
Updated for bitrot

>-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar > #nav-bar-inner,
>-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar > toolbaritem,
>-#main-window:not([active="true"]) > #navigator-toolbox > #PersonalToolbar,
>-#main-window:not([active="true"]) > #navigator-toolbox > #linktoolbar {
>-  opacity: 0.75;
Out of interest, why these particular elements only?
Comment 7 Stefan [:stefanh] 2010-05-20 11:46:48 PDT
The primary toolbar handles this itself and so does an added toolbar. We want this in the urlbar and in the throbber, though.

The PT and link toolbar are not native-styled, so we need the "fading" there.
Comment 8 Stefan [:stefanh] 2010-05-20 11:54:51 PDT
http://hg.mozilla.org/comm-central/rev/17735b9dc0ba

Note You need to log in before you can comment on or make changes to this bug.