Closed Bug 555508 Opened 11 years ago Closed 11 years ago

The 'active' attribute is gone, should instead use -moz-window-inactive pseudoclass

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a2

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch fix style rules (obsolete) — Splinter Review
The -moz-window-inactive pseudoclass introduced in bug 508482 made some styles rules in mac classic obsolete (they doesn't work anymore since the xul attribute was removed). We should use the new pseudoclass instead.
Attachment #435435 - Flags: review?(mnyromyr)
-#messengerWindow:not([active="true"]) > #mailContent > #messengerBox > #folderPaneBox {
+#folderPaneBox:-moz-window-inactive {
   background-color: #E8E8E8;
 }


As a curiosity, the old rule doesn't work on 2.0.x. Maybe caused by tabmail?
Attachment #435435 - Flags: superreview?(neil)
(In reply to comment #1)
> As a curiosity, the old rule doesn't work on 2.0.x. Maybe caused by tabmail?

Yep, caused by tabmail. Filed bug 555582 for a branch-fix.
Attachment #435435 - Flags: superreview?(neil) → superreview+
Turns out that I forgot pageInfo and DM :-/
Attachment #435435 - Attachment is obsolete: true
Attachment #436216 - Flags: review?(mnyromyr)
Attachment #435435 - Flags: review?(mnyromyr)
Attachment #436457 - Flags: review?
Comment on attachment 436457 [details] [diff] [review]
Updated for bitrot

I bitrotted myself in bug 556102...
Attachment #436457 - Flags: review? → review?(mnyromyr)
Attachment #436216 - Attachment is obsolete: true
Attachment #436216 - Flags: review?(mnyromyr)
Attachment #436457 - Flags: review?(mnyromyr) → review+
Attachment #436457 - Flags: superreview?(neil)
Comment on attachment 436457 [details] [diff] [review]
Updated for bitrot

>-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar > #nav-bar-inner,
>-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar > toolbaritem,
>-#main-window:not([active="true"]) > #navigator-toolbox > #PersonalToolbar,
>-#main-window:not([active="true"]) > #navigator-toolbox > #linktoolbar {
>-  opacity: 0.75;
Out of interest, why these particular elements only?
Attachment #436457 - Flags: superreview?(neil) → superreview+
The primary toolbar handles this itself and so does an added toolbar. We want this in the urlbar and in the throbber, though.

The PT and link toolbar are not native-styled, so we need the "fading" there.
http://hg.mozilla.org/comm-central/rev/17735b9dc0ba
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.1a1 → seamonkey2.1a2
You need to log in before you can comment on or make changes to this bug.